Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External speaker links #427

Closed
wants to merge 8 commits into from
Closed

External speaker links #427

wants to merge 8 commits into from

Conversation

kobexamoh
Copy link
Contributor

@kobexamoh kobexamoh commented Jun 4, 2020

Guten tag 👋 this PR tackles some of the functionality for #259 (or parts of it anyway). As like #408, I don't expect this to be super perfect off the bat, but would love feedback on it 😅

Ninja edit: I JUST saw the notification for #426; I'm going to undo this PR because it was based on previous code that #426 improves on. Brb: will bring it back once 426's been merged and I've built on it!

@cypress
Copy link

cypress bot commented Jun 4, 2020



Test summary

64 1 4 0


Run details

Project cree-intelligent-dictionary
Status Failed
Commit 1267b10
Started Jun 4, 2020 5:56 PM
Ended Jun 4, 2020 5:59 PM
Duration 02:33 💡
OS Linux Ubuntu Linux - 16.04
Browser Electron 73

View run in Cypress Dashboard ➡️


Failures

cypress/integration/recordings.spec.js Failed
1 Recordings > On the definition page > should open a link to the speaker's webpage in a new tab

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@kobexamoh kobexamoh closed this Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant