External speaker links #441
Conversation
Pain. Also, added some spacing to the speaker names to make clicking easier.
Remove the '.only' part and close off some brackets.
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
| @@ -26,6 +26,9 @@ <h1 id="head" class="definition-title"> | |||
| <ul class="recordings-list" data-cy="recordings-list"> | |||
| <!-- dynamically inserted speaker lists go here --> | |||
| </ul> | |||
| <div class="speaker-link"> | |||
There was a problem hiding this comment.
I think speaker-link is good here! It's a new semantic Block, and it could conceivably be moved elsewhere; it's not really an inseperable Element of definition.
CreeDictionary/CreeDictionary/templates/CreeDictionary/base.html
Outdated
Show resolved
Hide resolved
Remove comment. Co-authored-by: Eddie Antonio Santos <Eddie.Santos@nrc-cnrc.gc.ca>
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
eddieantonio
added
feature
Improvement
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
=========================================
Coverage ? 86.24%
=========================================
Files ? 71
Lines ? 2617
Branches ? 0
=========================================
Hits ? 2257
Misses ? 360
Partials ? 0
Continue to review full report at Codecov.
|
| createdSpeakerButton.addEventListener('click', () => audio.play()) | ||
| createdSpeakerButton.addEventListener('click', () => { | ||
| audio.play() | ||
| displaySpeakerBioLink(recordingData); |
| // generate a new link and append it to the page if there isn't already one | ||
| if (container.childElementCount < 1) { | ||
| // set the speaker-link text with the name of the speaker | ||
| createdTemplateNode.querySelector('slot[name="speaker-name"]').innerText = speakerName; |
Guten Tag 👋 back at it with a PR to tackle #259. I've marked this as a draft to get some feedback, so fire away!
The link to the speaker (under the buttons) 'works', but if some wordforms have a long list of speakers, I think it might be better to have it on the right hand side of the page.
But anyway. Have at it – if we need to go at it together, that's good too!