Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust gwMerge to support groundwork extensions #110

Closed
jbkolze opened this issue Sep 20, 2024 · 0 comments · Fixed by #111
Closed

Adjust gwMerge to support groundwork extensions #110

jbkolze opened this issue Sep 20, 2024 · 0 comments · Fixed by #111
Assignees
Labels
enhancement New feature or request

Comments

@jbkolze
Copy link
Contributor

jbkolze commented Sep 20, 2024

The current implementation of gwMerge only supports the base gw- prefix and classes without a prefix, i.e. those provided by a user. Ideally, extensions to groundwork (e.g. groundwork-water) will use their own prefixes that will also need to be supported by gwMerge.

Since v2.4, tailwind-merge supports "dynamic" prefixes that allow the user to semi-automatically account for potential prefixes as long as they fit an expected format. I propose that groundwork extensions follow a format of gw{\w*}-, e.g. gww- for groundwork-water. The gwMerge function can be upgraded to support this format and the function can be exposed as a library utility for use in its extensions.

@jbkolze jbkolze added the enhancement New feature or request label Sep 20, 2024
@jbkolze jbkolze self-assigned this Sep 20, 2024
@jbkolze jbkolze linked a pull request Sep 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant