Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support extensions in gwMerge #111

Merged
merged 5 commits into from
Sep 23, 2024
Merged

Conversation

jbkolze
Copy link
Contributor

@jbkolze jbkolze commented Sep 20, 2024

Adds support for extension prefixes, e.g. gww- for groundwork-water. Assumption is that groundwork extensions will be of the format gw{\w*}- -- this can be changed easily, or others can be added in the future if needed.

Successfully tested with a specialized groundwork-water <Card> being styled with gw-, gww-, and blank prefix (user) styles with full working conflict resolution (preferring last-received classNames).

No breaking changes -- modifies gwMerge in-place.

Godspeed to anyone who sets up a dev environment to fully test this -- prepare for an npm linking nightmare.

Dynamic prefix support requires v2.4.0+
Expand the implementation of gwMerge to account for prefixes used by
groundwork extensions, which will be expected to be in the format of
"gw{\w*}-"
@jbkolze jbkolze added enhancement New feature or request minor-bump labels Sep 20, 2024
@jbkolze jbkolze linked an issue Sep 20, 2024 that may be closed by this pull request
Copy link

Please set a versioning label of either major-bump, minor-bump, or patch-bump to the pull request.

@willbreitkreutz willbreitkreutz merged commit ec45d70 into main Sep 23, 2024
3 checks passed
@willbreitkreutz willbreitkreutz deleted the feature/110-gwmerge-extensions branch September 23, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor-bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust gwMerge to support groundwork extensions
2 participants