Fix var name #151
Merged
Fix var name #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptional positioning above or below the header.
* Create progress component and add import for lib * Create documentation page. Add Route + Link. * Ensure width is a whole % to avoid css issues
* expose defaultIndex on Tabs component * add defaultIndex prop documentation
* Add LinkProvider and Link components * Add hrefMap prop to LinkProvider Allows user to map a different prop key to the default href key so that internal groundwork usage still works, e.g. for React Router hrefMap="to" * Replace existing catalyst Links with gw version * Put the catalyst Link component back in its box * Update library internal links to use <Link> External links can remain as <a> * Forward ref in Link component Need to forward ref for Link to maintain compatibility with the redux-bundler routing pattern. * Export Link and LinkProvider with library * Add documentation for LinkProvider * Remove unnecessary statement * Add docs example demonstrating ClientRouter usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.