-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update detail industry spec for use in useeio #396
Conversation
@@ -60,18 +60,22 @@ attribution_sources: | |||
_sources_to_cache: | |||
Detail_Use_YEAR: ## Update year | |||
!include:Detail_Use_SUT.yaml | |||
industry_spec: !include:USEEIOv2_detail_target.yaml:industry_spec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if these FBS should still use the BEA_detail_target schema?
(I don't think it will make a difference in this case)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me if you want to drop it - I agree that it won't make a difference for this FBS. I included the industry spec here because if we are pulling in an industry spec from Detail_USE_SUT.yaml, I figured we might as well pull in the target industry spec instead of what we have in the Detail Use yaml. But I don't have strong feelings
'33599', '33611', '33621', '33641', '33661', '33699', | ||
'33712', '33721', '33911', '51731', '52411', '54151', | ||
'562', '72251','92', 'F010'] | ||
NAICS_7: ['562212', '562219', '562920'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to remember where we define the 7-digit sectors for waste?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waste naics are defined here in the HIO repo - we should add those names to crosswalks in flowsa for 2012 and 2017 naics. I can do that in a few hours
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the 7-digit waste NAICS are included in the flowsa naics crosswalks
I'm currently comparing to the GHG FBS we used previously ( |
ok I dropped the 7 digit codes because we actually do the 6 --> 7 digit split in HIO. I'm good with pulling this in. @catherinebirney I will let you decide how to handle versioning. |
@@ -60,18 +60,22 @@ attribution_sources: | |||
_sources_to_cache: | |||
Detail_Use_YEAR: ## Update year | |||
!include:Detail_Use_SUT.yaml | |||
industry_spec: !include:BEA_detail_target.yaml:industry_spec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bl-young This industry_spec isn't necessary now because it is the exact info pulled from Detail_Use_SUT.yaml, so I think these 4 lines should be deleted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right. ok
Ok let's pull into the fba_hotfix branch, which I'll wrap up today or tomorrow and then do a v2.0.1 release |
No description provided.