Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update result object names #315

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Update result object names #315

merged 2 commits into from
Dec 5, 2024

Conversation

bl-young
Copy link
Collaborator

@bl-young bl-young commented Sep 6, 2024

These are updated from LCI to G and LCIA to H to match the terminology in the Imports report.

Final perspective is indicated with l and direct perspective with r.

Existing scripts outside of useeior using the calculation result objects will no longer work with this update. We may want to align this with a MINOR version update (e.g. 1.7.0)

@bl-young bl-young linked an issue Sep 6, 2024 that may be closed by this pull request
@bl-young bl-young mentioned this pull request Sep 6, 2024
@bl-young bl-young added this to the v1.7 milestone Oct 22, 2024
@bl-young
Copy link
Collaborator Author

bl-young commented Dec 5, 2024

Now that we've minted 1.6.1, I'm going to start pulling these in. @WesIngwersen are you good with this change?

@bl-young bl-young merged commit 5a6a62a into develop Dec 5, 2024
6 checks passed
@bl-young bl-young deleted the issue_303 branch December 5, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align imports nomenclature with report
2 participants