typo: Bass is not the same as Base in the AudioPlayback context #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I delete* some of the bundled mp3's in my local build. I'm used to the error in the logs and never really paid attention to them, but with the recent removal of Bass for the audio decoding on Windows (#955), I started wondering why my Linux logs were referring to
Bassof all things in the first place:TAudioPlayback_Bass.OpenStream
Turns out it's just a typo. A very confusing one because both UAudioPlaybackBase.pas and UAudioPlayback_Bass.pas are actual files.
* = I actually rename stuff like
applause.mp3tonull.mp3in UMusic TSoundLibrary.LoadSounds, but the result is the same