Skip to content

Remove dependency between BUILTIN and postulates #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 40 commits into
base: master
Choose a base branch
from

Conversation

fredrik-bakke
Copy link
Collaborator

@fredrik-bakke fredrik-bakke commented Mar 20, 2025

This PR is preparation for #1379.

The BUILTIN pragma cannot be invoked inside of a parametrized module, which in practice means that we cannot have a dependency on an axiom in a module where a BUILTIN is invoked. This PR resolves that by moving dependencies around and splitting a couple of files into smaller parts.

@fredrik-bakke
Copy link
Collaborator Author

After some preliminary experimentation, there are some technical issues to point out:

  • Named modules with parameters are incompatible with BUILTIN pragmas, so I've refactored all modules that have such a pragma to depend only on files that are not (transitively) dependent on any module that uses funext anywhere.
  • There's an issue with public imports when using named imports. See the current typechecking error. Essentially, such definitions are duplicated in the scope, leading to "ambiguous names"

@fredrik-bakke
Copy link
Collaborator Author

fredrik-bakke commented Mar 20, 2025

The python scripts will be removed later.

EDIT: Removed

@fredrik-bakke
Copy link
Collaborator Author

fredrik-bakke commented Mar 20, 2025

I've refactored all modules that have such a pragma to depend only on files that are not (transitively) dependent on any module that uses funext anywhere.

*If we get to that stage, I can pull these changes to a different branch for a separate review later.

@fredrik-bakke fredrik-bakke mentioned this pull request Mar 24, 2025
11 tasks
@fredrik-bakke fredrik-bakke changed the title Depostulate function extensionality Resolve dependency issues between BUILTIN and postulates Mar 24, 2025
@fredrik-bakke fredrik-bakke changed the title Resolve dependency issues between BUILTIN and postulates Remove dependency between BUILTIN and postulates Mar 24, 2025
@fredrik-bakke fredrik-bakke marked this pull request as ready for review March 25, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant