Skip to content

More logic #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

fredrik-bakke
Copy link
Collaborator

Pulls logic additions from #1264.

Copy link
Collaborator

@VojtechStep VojtechStep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I managed to go through the first half of files, hopefully to be continued some time next week


The
{{#concept "double negation image" Disambiguation="of a map" Agda=double-negation-im}}
of `f : A → B` is the essentially unique type that factorizes `f` as a
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You write about an essentially unique type, but I see no reference to uniqueness (or universal properties) in this file. Honestly this paragraph is pretty cryptic, and I find it hard to believe it's at all understandable to many people outside Martín's sphere of influence 😅. Would you mind rephrasing it, and at least drawing a diagram?

false ≤ false
false ≤ true
true ≤ true
true ≰ false.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would a non-inequality be a generator of an inductive relation? And since the relation is not literally given by the inequalities, wouldn't it be better to write what it actually is defined as, and then note an alternative way of looking at it? I think I noticed this trend of the prose and Agda matching only up to (sometimes unproven) equivalence

leq-right-or-bool {x} {true} p = star
leq-right-or-bool {false} {false} p = star

leq-or-bool'' :
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should have better names, but I'm currently too tired to come up with any

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is one direction of the universal property of or, so something like is-lower-bound-or-bool should work

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, upper bound*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants