Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly use global cache + mixed routes fix #820

Merged
merged 10 commits into from
Feb 13, 2025

Conversation

xrsv
Copy link
Contributor

@xrsv xrsv commented Feb 5, 2025

Couple changes to have a consistent caching experience + to properly handle mixed protocol

  • Only enter cache when all enabled protocols are requested
    • also account for UniversalRouterVersion.V1_2 vs UniversalRouterVersion.V2_0 where different protocols are in play
  • when mixed is part of the protocols, then find mixed routes from the provided protocols. E.g. v2,v4,mixed will result in v2+v4+mixed(v2,v4) search. Also protocols=mixed is now not valid/permitted (will 404 in routing api)

Tests

  • added unit tests
  • tested on personal endpoint
  • run routing api e2e tests against personal endpoint

Copy link

graphite-app bot commented Feb 5, 2025

Graphite Automations

"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (02/05/25)

2 reviewers were added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation.

@jsy1218
Copy link
Member

jsy1218 commented Feb 12, 2025

lgtm. my only suggestion is that we monitor the mixed related metrics counts after rollout, to see if it changes. it shouldn't, since swappers should usually request all protocol versions.

@xrsv xrsv merged commit 9f591ce into main Feb 13, 2025
27 of 29 checks passed
@xrsv xrsv deleted the xrsv/cache-mixed-proper-fix-v1 branch February 13, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants