-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: properly use global cache + mixed routes fix #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Graphite Automations"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (02/05/25)2 reviewers were added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation. |
jsy1218
approved these changes
Feb 12, 2025
lgtm. my only suggestion is that we monitor the mixed related metrics counts after rollout, to see if it changes. it shouldn't, since swappers should usually request all protocol versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple changes to have a consistent caching experience + to properly handle
mixed
protocolUniversalRouterVersion.V1_2
vsUniversalRouterVersion.V2_0
where different protocols are in playmixed
is part of theprotocols
, then find mixed routes from the provided protocols. E.g.v2,v4,mixed
will result in v2+v4+mixed(v2,v4) search. Alsoprotocols=mixed
is now not valid/permitted (will 404 in routing api)Tests