Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump sor to 4.18.1 - bump v4-sdk to fix price impact #829

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

jsy1218
Copy link
Member

@jsy1218 jsy1218 commented Feb 13, 2025

It used to be at 5% for a small trade size USDC -> ETH trade https://uniswapteam.slack.com/archives/C03BSGBKWA0/p1739401264687879?thread_ts=1739399166.927229&cid=C03BSGBKWA0

Copy link
Member Author

jsy1218 commented Feb 13, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jsy1218 jsy1218 marked this pull request as ready for review February 13, 2025 20:44
@jsy1218 jsy1218 requested a review from a team as a code owner February 13, 2025 20:44
@jsy1218 jsy1218 changed the title chore: bump sor to 4.17.18 - bump v4-sdk to fix price impact chore: bump sor to 4.18.1 - bump v4-sdk to fix price impact Feb 13, 2025
@jsy1218 jsy1218 merged commit 02e1aed into main Feb 13, 2025
24 of 30 checks passed
Copy link
Member Author

jsy1218 commented Feb 13, 2025

Merge activity

  • Feb 13, 5:13 PM EST: A user merged this pull request with Graphite.

@jsy1218 jsy1218 deleted the siyujiang/sor-4.17.18-v4-price-impact branch February 13, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants