chore: bump sor to 4.18.1 - bump v4-sdk to fix price impact #829
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
v4-sdk route mid price calculation should not refactor
What is the new behavior (if this is a feature change)?
Release:
fix(universal-router-sdk): bump v4-sdk to 1.19.4 and router-sdk to 1.22.2 sdks#306
fix(router-sdk): bump v4-sdk to 1.19.4 sdks#305
fix(v4-sdk): simplify
midPrice
inRoute
entity (#180) sdks#304Other information:
I tested on my local, and see price impact is reasonable now https://app.warp.dev/block/K38TfreQI6R0cJkvMYkOhE.
It used to be at 5% for a small trade size USDC -> ETH trade https://uniswapteam.slack.com/archives/C03BSGBKWA0/p1739401264687879?thread_ts=1739399166.927229&cid=C03BSGBKWA0