Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parent static field instrumentation #183

Merged
merged 3 commits into from
Mar 1, 2024

Conversation

IlyaMuravjov
Copy link
Collaborator

@IlyaMuravjov IlyaMuravjov commented Feb 21, 2024

In JVM bytecode (and in JcRawInst) static fields can be accessed via child class. That causes bytecode transformation of the added example.ParentStaticFieldUser class to fail with the following exception, this PR fixes that issue.

java.lang.IllegalStateException: Field not found
	at org.usvm.instrumentation.instrumentation.JcInstructionTracer.encodeStaticFieldAccess(JcInstructionTracer.kt:133)
	at org.usvm.instrumentation.instrumentation.JcRuntimeTraceInstrumenter.instrumentMethod(JcRuntimeTraceInstrumenter.kt:66)
	at org.usvm.instrumentation.instrumentation.JcRuntimeTraceInstrumenter.instrumentClass(JcRuntimeTraceInstrumenter.kt:94)
	at org.usvm.instrumentation.agent.ClassTransformer.transform(ClassTransformer.kt:42)
	at java.instrument/java.lang.instrument.ClassFileTransformer.transform(ClassFileTransformer.java:244)
	at java.instrument/sun.instrument.TransformerManager.transform(TransformerManager.java:188)
	at java.instrument/sun.instrument.InstrumentationImpl.transform(InstrumentationImpl.java:541)
	at java.base/java.lang.ClassLoader.defineClass1(Native Method)
	at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1013)
	at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150)
	at org.usvm.instrumentation.classloader.WorkerClassLoader.findClass(WorkerClassLoader.kt:109)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:588)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521)
	at org.usvm.instrumentation.classloader.WorkerClassLoader.loadClass(WorkerClassLoader.kt:89)
	at java.base/java.lang.Class.forName0(Native Method)
	at java.base/java.lang.Class.forName(Class.java:488)
	at java.base/java.lang.Class.forName(Class.java:467)
	at org.usvm.instrumentation.util.JacodbKt.toJavaMethod(Jacodb.kt:138)
	at org.usvm.instrumentation.testcase.executor.UTestExpressionExecutor.executeUTestStaticMethodCall(UTestExpressionExecutor.kt:293)
	at org.usvm.instrumentation.testcase.executor.UTestExpressionExecutor.exec(UTestExpressionExecutor.kt:66)
	at org.usvm.instrumentation.testcase.executor.UTestExpressionExecutor.executeUTestInst-IoAF18A(UTestExpressionExecutor.kt:39)
	at org.usvm.instrumentation.rd.UTestExecutor.executeUTest(UTestExecutor.kt:96)
	at org.usvm.instrumentation.rd.InstrumentedProcess.callUTest(InstrumentedProcess.kt:204)
	at org.usvm.instrumentation.rd.InstrumentedProcess.access$callUTest(InstrumentedProcess.kt:33)
	at org.usvm.instrumentation.rd.InstrumentedProcess$setup$1.invoke(InstrumentedProcess.kt:136)
	at org.usvm.instrumentation.rd.InstrumentedProcess$setup$1.invoke(InstrumentedProcess.kt:134)
	at org.usvm.instrumentation.rd.InstrumentedProcess$measureExecutionForTermination$1.invoke(InstrumentedProcess.kt:219)
	at com.jetbrains.rd.framework.IRdEndpoint$set$1.invoke(TaskInterfaces.kt:182)
	at com.jetbrains.rd.framework.IRdEndpoint$set$1.invoke(TaskInterfaces.kt:182)
	at com.jetbrains.rd.framework.impl.RdCall.onWireReceived(RdTask.kt:365)
	at com.jetbrains.rd.framework.MessageBroker$invoke$2$2.invoke(MessageBroker.kt:57)
	at com.jetbrains.rd.framework.MessageBroker$invoke$2$2.invoke(MessageBroker.kt:56)
	at com.jetbrains.rd.framework.impl.ProtocolContexts.readMessageContextAndInvoke(ProtocolContexts.kt:148)
	at com.jetbrains.rd.framework.MessageBroker$invoke$2.invoke(MessageBroker.kt:56)
	at com.jetbrains.rd.framework.MessageBroker$invoke$2.invoke(MessageBroker.kt:54)
	at com.jetbrains.rd.util.threading.SingleThreadSchedulerBase.queue$lambda-3(SingleThreadScheduler.kt:41)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:833)

@IlyaMuravjov IlyaMuravjov force-pushed the ilya_m/parent-static-field-instrumentation branch from bcf7820 to ba4fae6 Compare February 21, 2024 15:22
@IlyaMuravjov IlyaMuravjov changed the title Add failing test for parent static field instrumentation Fix parent static field instrumentation Feb 21, 2024
@IlyaMuravjov IlyaMuravjov merged commit e8faa82 into main Mar 1, 2024
1 check passed
@IlyaMuravjov IlyaMuravjov deleted the ilya_m/parent-static-field-instrumentation branch March 1, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants