-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds docs for Personal Myradio Dev #372
base: development
Are you sure you want to change the base?
Conversation
INSERT INTO myury.api_key_auth (key_string, typeid) VALUES ('ARANDOMSTRINGOFCHARACTERS', (SELECT typeid FROM l_action WHERE phpconstant = 'AUTH_APISUDO')); | ||
``` | ||
|
||
[please choose a better key than 'ARANDOMSTRINGOFCHARACTERS'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
square brackets is markdown syntax - and you should probably give an example of generating a random key like openssl rand -hex 32
- which should come before the SQL statements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump
In Config.toml: | ||
|
||
``` | ||
myradio_api = "https://{hostname}/api/v2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should probably just explain how to connect it to localhost, don't bother with https/another reverse proxy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the problem I encoured is there no easy way of running it over https which is required by myradio apache server, without reverse proxying through a domain.
as it looks like you might need to gen some of your own certificates before you can use api
x509: cannot validate certificate
I'll see if I can make it work on localhost
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you go to http://localhost:7080/myradio/ rather than https://localhost:4443, it will work over http (if you have already set up a local instance, you need to change the port in Config:$base_url
in src/MyRadio_Config.local.php
)
Co-authored-by: Ash <ash@ashhhleyyy.dev>
Co-authored-by: Ash <ash@ashhhleyyy.dev>
Co-authored-by: Ash <ash@ashhhleyyy.dev>
Co-authored-by: Ash <ash@ashhhleyyy.dev>
also, just a note, but in the UI you can apply review suggestions all at once, rather than it creating a separate commit for each |
Moves docs from my radio to 2016-site