Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed URI encoding with special characters #117

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

amarcionek
Copy link

Fixes issue #105 by running the uri through URLEncoder.encode and then converting allowable characters :, / and [space] back.

Fixes issue Upplication#105 by running the uri through URLEncoder.encode and then
converting allowable characters :, / and [space] back.
@amarcionek
Copy link
Author

FYI: For what it's worth, I took guidance from Amazon's SDK: https://github.com/aws/aws-sdk-java/blob/master/aws-java-sdk-s3/src/main/java/com/amazonaws/services/s3/AmazonS3URI.java method preprocessUrlStr.

@carlspring
Copy link

Hi,

@amarcionek , we would like to thank you for your work on this and are sad to see that it was not accepted and merged in this project.

Would you like to fix and test it in our spin-off (rebranded fork) -- s3fs-nio -- where we have now also migrated our code to AWS SDK v2 (see carlspring/s3fs-nio#63)? As this upstream is now clearly dead (#135), please feel free to check out our work! We've identified this pull request as one of interest for review in carlspring/s3fs-nio#72.

We would like to rebuild a community around the s3fs-nio and would be thrilled, if you'd like to join us in our efforts to build a stable library that is well-maintained, documented and regularly released.

Kind regards,

Martin Todorov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants