fix: Errors for Not Found Members

VATSIM-UK · Feb 24, 2024 · 26e760e · 26e760e
1 parent 7c2d39f
commit 26e760e
Showing 1 changed file with 6 additions and 15 deletions.
diff --git a/app/Jobs/UpdateMember.php b/app/Jobs/UpdateMember.php
@@ -72,7 +72,12 @@ public function handle()
                 'Authorization' => $token,
             ])->withUserAgent('VATSIMUK')->get($url);
 
-            $response->throwIfStatus(404);
+            if ($response->status() === 404) {
+                Log::info("Member {$this->accountID} not found in VATSIM API. Deleting.");
+                $member->delete();
+
+                return;
+            }
 
             $response = $response->json();
 
@@ -97,20 +102,6 @@ public function handle()
                 'pilottime' => (string) 0,
                 'cid' => $response['id'],
             ];
-        } catch (RequestException $e) {
-            if ($e->response->status() === 404) {
-                Log::info("Member {$this->accountID} not found in VATSIM API. Deleting.");
-                $member->delete();
-
-                return;
-            }
-
-            Bugsnag::notifyException($e, function ($report) {
-                $report->setSeverity('error');
-                $report->setMetaData([
-                    'accountID' => $this->accountID,
-                ]);
-            });
         } catch (\Exception $e) {
             Bugsnag::notifyException($e, function ($report) {
                 $report->setSeverity('error');