wip

VATSIM-UK · Jan 20, 2025 · 5e6837d · 5e6837d
1 parent 3d2e426
commit 5e6837d
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 10 deletions.
diff --git a/app/Http/Controllers/External/VatsimNet/ProcessVatsimNetWebhook.php b/app/Http/Controllers/External/VatsimNet/ProcessVatsimNetWebhook.php
@@ -3,6 +3,9 @@
 namespace App\Http\Controllers\External\VatsimNet;
 
 use App\Http\Controllers\BaseController;
+use App\Jobs\ExternalServices\VatsimNet\Webhooks\MemberChangedAction;
+use App\Jobs\ExternalServices\VatsimNet\Webhooks\MemberCreatedAction;
+use Illuminate\Support\Facades\Log;
 
 class ProcessVatsimNetWebhook extends BaseController
 {
@@ -15,10 +18,19 @@ public function __invoke()
         }
 
         foreach (request()->json('actions') as $action) {
-            $class = config("services.vatsim-net.webhook.jobs.{$action['action']}");
-            if ($class && class_exists($class)) {
-                dispatch(new $class(request()->json('resource'), $action))->afterResponse();
+            $class = match ($action['action']) {
+                'member_created_action' => MemberCreatedAction::class,
+                'member_changed_action' => MemberChangedAction::class,
+                default => null,
+            };
+
+            if (! $class) {
+                Log::error("Unhandled webhook from VATSIM.net: {$action['action']}");
+
+                continue;
             }
+
+            dispatch(new $class(request()->json('resource'), $action))->afterResponse();
         }
 
         return response()->json([

diff --git a/config/services.php b/config/services.php
@@ -1,8 +1,5 @@
 <?php
 
-use App\Jobs\ExternalServices\VatsimNet\Webhooks\MemberChangedAction;
-use App\Jobs\ExternalServices\VatsimNet\Webhooks\MemberCreatedAction;
-
 return [
 
     /*
@@ -81,10 +78,6 @@
     'vatsim-net' => [
         'webhook' => [
             'key' => env('VATSIM_NET_WEBHOOK_KEY'),
-            'jobs' => [
-                'member_created_action' => MemberCreatedAction::class,
-                'member_changed_action' => MemberChangedAction::class,
-            ],
         ],
         'api' => [
             'base' => env('VATSIM_API_BASE', 'https://api.vatsim.net/api/'),