Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: port Containerfile to Vib recipe format #179

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

kbdharun
Copy link
Member

Changes

This PR ports the Containerfile to use the Vib recipe format. I have tested all the changes locally with the image https://github.com/kbdharun/VanillaOS-website/pkgs/container/website along with the command docker run -d -p 6080:6080 ghcr.io/kbdharun/website:main.

Details

Current Containerfile:

FROM node:20.10.0

WORKDIR /app
COPY . .

RUN npm install
RUN npm run build

EXPOSE 6080

CMD ["npm", "run", "start"]

New Vib Containerfile:

# Stage: build
FROM node:lts AS build
LABEL maintainer='Vanilla OS Contributors'
EXPOSE 6080/
ADD includes.container /
ADD sources /sources
RUN mv /sources/init /app
RUN cd /app && npm install && npm run build
CMD ["sh","-c","cd /app && npm run start"]

Signed-off-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@mirkobrombin mirkobrombin merged commit 65067e3 into Vanilla-OS:v2 Apr 22, 2024
1 check passed
@kbdharun kbdharun deleted the feat/port-to-vib branch April 22, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants