Skip to content

Commit

Permalink
T
Browse files Browse the repository at this point in the history
  • Loading branch information
@Vectorized
Vectorized committed Jan 22, 2024
1 parent 6a1cdd3 commit b903b9f
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 43 deletions.
80 changes: 40 additions & 40 deletions .gas-snapshot
View file
Original file line number Diff line number Diff line change
Expand Up @@ -227,15 +227,15 @@ ERC4337FactoryTest:test__codesize() (gas: 13520)
ERC4337Test:testCdFallback() (gas: 443989)
ERC4337Test:testCdFallback2() (gas: 1140699)
ERC4337Test:testDelegateExecute() (gas: 369570)
ERC4337Test:testDelegateExecute(uint256) (runs: 256, μ: 355116, ~: 344555)
ERC4337Test:testDelegateExecute(uint256) (runs: 256, μ: 357133, ~: 344555)
ERC4337Test:testDelegateExecuteRevertsIfOwnerSlotValueChanged() (gas: 319282)
ERC4337Test:testDepositFunctions() (gas: 502955)
ERC4337Test:testDirectStorage() (gas: 70413)
ERC4337Test:testDisableInitializerForImplementation() (gas: 1177324)
ERC4337Test:testETHReceived() (gas: 16584)
ERC4337Test:testExecute() (gas: 382786)
ERC4337Test:testExecuteBatch() (gas: 692605)
ERC4337Test:testExecuteBatch(uint256) (runs: 256, μ: 520473, ~: 368308)
ERC4337Test:testExecuteBatch(uint256) (runs: 256, μ: 518151, ~: 368302)
ERC4337Test:testInitializer() (gas: 285192)
ERC4337Test:testIsValidSignature() (gas: 111663)
ERC4337Test:testIsValidSignaturePersonalSign() (gas: 96270)
Expand Down Expand Up @@ -266,18 +266,18 @@ ERC4626Test:testWithdrawWithNotEnoughUnderlyingAmountReverts() (gas: 144074)
ERC4626Test:testWithdrawZero() (gas: 52807)
ERC4626Test:test__codesize() (gas: 41067)
ERC6551Test:testCdFallback() (gas: 894585)
ERC6551Test:testDeployERC6551(uint256) (runs: 256, μ: 171221, ~: 168765)
ERC6551Test:testDeployERC6551(uint256) (runs: 256, μ: 171064, ~: 168765)
ERC6551Test:testDeployERC6551Proxy() (gas: 80751)
ERC6551Test:testExecute() (gas: 507949)
ERC6551Test:testExecuteBatch() (gas: 817049)
ERC6551Test:testExecuteBatch(uint256) (runs: 256, μ: 635264, ~: 761670)
ERC6551Test:testExecuteBatch(uint256) (runs: 256, μ: 655790, ~: 761670)
ERC6551Test:testInitializeERC6551ProxyImplementation() (gas: 189807)
ERC6551Test:testIsValidSignature() (gas: 187662)
ERC6551Test:testOnERC1155BatchReceived() (gas: 1526548)
ERC6551Test:testOnERC1155Received() (gas: 1523904)
ERC6551Test:testOnERC721Received() (gas: 1508551)
ERC6551Test:testOnERC721ReceivedCycles() (gas: 1714607)
ERC6551Test:testOnERC721ReceivedCyclesWithDifferentChainIds(uint256) (runs: 256, μ: 448782, ~: 454437)
ERC6551Test:testOnERC721ReceivedCyclesWithDifferentChainIds(uint256) (runs: 256, μ: 449092, ~: 454409)
ERC6551Test:testSupportsInterface() (gas: 169393)
ERC6551Test:testUpgrade() (gas: 1154917)
ERC6551Test:test__codesize() (gas: 48064)
Expand Down Expand Up @@ -319,54 +319,54 @@ ERC6909Test:testTransferOverMaxUintReverts(address,uint256,uint256,uint256) (run
ERC6909Test:test__codesize() (gas: 26802)
ERC721HooksTest:testERC721Hooks() (gas: 2944418)
ERC721HooksTest:test__codesize() (gas: 10028)
ERC721Test:testApprove(uint256) (runs: 256, μ: 108106, ~: 108121)
ERC721Test:testApproveAll(uint256) (runs: 256, μ: 47976, ~: 40334)
ERC721Test:testApproveBurn(uint256) (runs: 256, μ: 86789, ~: 86847)
ERC721Test:testApproveNonExistentReverts(uint256,address) (runs: 256, μ: 33640, ~: 33571)
ERC721Test:testApproveUnauthorizedReverts(uint256) (runs: 256, μ: 83293, ~: 82356)
ERC721Test:testApprove(uint256) (runs: 256, μ: 108116, ~: 108135)
ERC721Test:testApproveAll(uint256) (runs: 256, μ: 47670, ~: 40334)
ERC721Test:testApproveBurn(uint256) (runs: 256, μ: 86799, ~: 86847)
ERC721Test:testApproveNonExistentReverts(uint256,address) (runs: 256, μ: 33639, ~: 33571)
ERC721Test:testApproveUnauthorizedReverts(uint256) (runs: 256, μ: 83227, ~: 82354)
ERC721Test:testAuthorizedEquivalence(address,bool,bool) (runs: 256, μ: 748, ~: 743)
ERC721Test:testAux(uint256) (runs: 256, μ: 191849, ~: 193040)
ERC721Test:testBurn(uint256) (runs: 256, μ: 83053, ~: 94044)
ERC721Test:testAux(uint256) (runs: 256, μ: 191918, ~: 193054)
ERC721Test:testBurn(uint256) (runs: 256, μ: 82721, ~: 93952)
ERC721Test:testBurnNonExistentReverts(uint256) (runs: 256, μ: 10783, ~: 10783)
ERC721Test:testCannotExceedMaxBalance() (gas: 169072)
ERC721Test:testDoubleBurnReverts(uint256) (runs: 256, μ: 63578, ~: 63525)
ERC721Test:testDoubleMintReverts(uint256) (runs: 256, μ: 79147, ~: 79171)
ERC721Test:testEverything(uint256) (runs: 256, μ: 309856, ~: 302059)
ERC721Test:testExtraData(uint256) (runs: 256, μ: 99052, ~: 99131)
ERC721Test:testDoubleBurnReverts(uint256) (runs: 256, μ: 63580, ~: 63582)
ERC721Test:testDoubleMintReverts(uint256) (runs: 256, μ: 79140, ~: 79170)
ERC721Test:testEverything(uint256) (runs: 256, μ: 319517, ~: 378365)
ERC721Test:testExtraData(uint256) (runs: 256, μ: 99017, ~: 99091)
ERC721Test:testExtraData2(uint256,uint256) (runs: 256, μ: 54285, ~: 53934)
ERC721Test:testIsApprovedOrOwner(uint256) (runs: 256, μ: 135193, ~: 135195)
ERC721Test:testMint(uint256) (runs: 256, μ: 82826, ~: 82870)
ERC721Test:testMintAndSetExtraDataUnchecked(uint256) (runs: 256, μ: 84346, ~: 84378)
ERC721Test:testMintAndSetExtraDataUncheckedWithOverwrite(uint256,uint96) (runs: 256, μ: 83608, ~: 83670)
ERC721Test:testIsApprovedOrOwner(uint256) (runs: 256, μ: 135190, ~: 135206)
ERC721Test:testMint(uint256) (runs: 256, μ: 82829, ~: 82870)
ERC721Test:testMintAndSetExtraDataUnchecked(uint256) (runs: 256, μ: 84344, ~: 84378)
ERC721Test:testMintAndSetExtraDataUncheckedWithOverwrite(uint256,uint96) (runs: 256, μ: 83607, ~: 83515)
ERC721Test:testMintToZeroReverts(uint256) (runs: 256, μ: 39209, ~: 39209)
ERC721Test:testOwnerOfNonExistent(uint256) (runs: 256, μ: 33399, ~: 33338)
ERC721Test:testSafeMintToEOA(uint256) (runs: 256, μ: 83341, ~: 83391)
ERC721Test:testSafeMintToERC721Recipient(uint256) (runs: 256, μ: 409316, ~: 410424)
ERC721Test:testSafeMintToERC721RecipientWithData(uint256,bytes) (runs: 256, μ: 470749, ~: 460016)
ERC721Test:testOwnerOfNonExistent(uint256) (runs: 256, μ: 33393, ~: 33338)
ERC721Test:testSafeMintToEOA(uint256) (runs: 256, μ: 83338, ~: 83369)
ERC721Test:testSafeMintToERC721Recipient(uint256) (runs: 256, μ: 409322, ~: 410424)
ERC721Test:testSafeMintToERC721RecipientWithData(uint256,bytes) (runs: 256, μ: 470741, ~: 460012)
ERC721Test:testSafeMintToERC721RecipientWithWrongReturnData(uint256) (runs: 256, μ: 169926, ~: 169926)
ERC721Test:testSafeMintToERC721RecipientWithWrongReturnDataWithData(uint256,bytes) (runs: 256, μ: 171141, ~: 171088)
ERC721Test:testSafeMintToNonERC721RecipientReverts(uint256) (runs: 256, μ: 100388, ~: 100388)
ERC721Test:testSafeMintToNonERC721RecipientWithDataReverts(uint256,bytes) (runs: 256, μ: 101635, ~: 101582)
ERC721Test:testSafeMintToRevertingERC721RecipientReverts(uint256) (runs: 256, μ: 203045, ~: 203045)
ERC721Test:testSafeMintToRevertingERC721RecipientWithDataReverts(uint256,bytes) (runs: 256, μ: 204281, ~: 204228)
ERC721Test:testSafeTransferFromToEOA(uint256) (runs: 256, μ: 121889, ~: 122021)
ERC721Test:testSafeTransferFromToERC721Recipient(uint256) (runs: 256, μ: 470899, ~: 472038)
ERC721Test:testSafeTransferFromToERC721RecipientWithData(uint256,bytes) (runs: 256, μ: 532327, ~: 521657)
ERC721Test:testSafeTransferFromToERC721RecipientWithWrongReturnDataReverts(uint256) (runs: 256, μ: 200887, ~: 200937)
ERC721Test:testSafeTransferFromToERC721RecipientWithWrongReturnDataWithDataReverts(uint256,bytes) (runs: 256, μ: 202121, ~: 202133)
ERC721Test:testSafeTransferFromToNonERC721RecipientReverts(uint256) (runs: 256, μ: 131287, ~: 131226)
ERC721Test:testSafeTransferFromToNonERC721RecipientWithDataReverts(uint256,bytes) (runs: 256, μ: 132595, ~: 132605)
ERC721Test:testSafeTransferFromToRevertingERC721RecipientReverts(uint256) (runs: 256, μ: 233954, ~: 234005)
ERC721Test:testSafeTransferFromToRevertingERC721RecipientWithDataReverts(uint256,bytes) (runs: 256, μ: 235258, ~: 235268)
ERC721Test:testSafeTransferFromToEOA(uint256) (runs: 256, μ: 121894, ~: 122013)
ERC721Test:testSafeTransferFromToERC721Recipient(uint256) (runs: 256, μ: 470900, ~: 472025)
ERC721Test:testSafeTransferFromToERC721RecipientWithData(uint256,bytes) (runs: 256, μ: 532328, ~: 521600)
ERC721Test:testSafeTransferFromToERC721RecipientWithWrongReturnDataReverts(uint256) (runs: 256, μ: 200882, ~: 200936)
ERC721Test:testSafeTransferFromToERC721RecipientWithWrongReturnDataWithDataReverts(uint256,bytes) (runs: 256, μ: 202114, ~: 202125)
ERC721Test:testSafeTransferFromToNonERC721RecipientReverts(uint256) (runs: 256, μ: 131289, ~: 131226)
ERC721Test:testSafeTransferFromToNonERC721RecipientWithDataReverts(uint256,bytes) (runs: 256, μ: 132597, ~: 132608)
ERC721Test:testSafeTransferFromToRevertingERC721RecipientReverts(uint256) (runs: 256, μ: 233957, ~: 234013)
ERC721Test:testSafeTransferFromToRevertingERC721RecipientWithDataReverts(uint256,bytes) (runs: 256, μ: 235256, ~: 235265)
ERC721Test:testSafetyOfCustomStorage(uint256,uint256) (runs: 256, μ: 1063, ~: 713)
ERC721Test:testTransferFrom() (gas: 85772)
ERC721Test:testTransferFrom(uint256) (runs: 256, μ: 114037, ~: 112464)
ERC721Test:testTransferFromApproveAll(uint256) (runs: 256, μ: 119323, ~: 119293)
ERC721Test:testTransferFromNotExistentReverts(address,address,uint256) (runs: 256, μ: 34031, ~: 34014)
ERC721Test:testTransferFromNotOwner(uint256) (runs: 256, μ: 84741, ~: 84719)
ERC721Test:testTransferFromSelf(uint256) (runs: 256, μ: 92708, ~: 92697)
ERC721Test:testTransferFromToZeroReverts(uint256) (runs: 256, μ: 79078, ~: 79051)
ERC721Test:testTransferFromWrongFromReverts(address,uint256) (runs: 256, μ: 80439, ~: 80442)
ERC721Test:testTransferFrom(uint256) (runs: 256, μ: 114420, ~: 112610)
ERC721Test:testTransferFromApproveAll(uint256) (runs: 256, μ: 119308, ~: 119293)
ERC721Test:testTransferFromNotExistentReverts(address,address,uint256) (runs: 256, μ: 34033, ~: 34014)
ERC721Test:testTransferFromNotOwner(uint256) (runs: 256, μ: 84759, ~: 84728)
ERC721Test:testTransferFromSelf(uint256) (runs: 256, μ: 92719, ~: 92693)
ERC721Test:testTransferFromToZeroReverts(uint256) (runs: 256, μ: 79077, ~: 79051)
ERC721Test:testTransferFromWrongFromReverts(address,uint256) (runs: 256, μ: 80443, ~: 80442)
ERC721Test:test__codesize() (gas: 43715)
FixedPointMathLibTest:testAbs() (gas: 578)
FixedPointMathLibTest:testAbs(int256) (runs: 256, μ: 516, ~: 485)
Expand Down
5 changes: 2 additions & 3 deletions src/tokens/ERC721.sol
View file
Original file line number Diff line number Diff line change
Expand Up @@ -487,9 +487,8 @@ abstract contract ERC721 {
_afterTokenTransfer(address(0), to, id);
}

/// @dev Mints token `id` to `to` and updates the extra data for token `id` to `value`,
/// but without checking if the token `id` already exists,
/// as `id` will usually be from an auto-incrementing counter.
/// @dev Mints token `id` to `to`, and updates the extra data for token `id` to `value`.
/// Does NOT check if token `id` already exists (`id` is usually from an auto-incrementing counter).
///
/// Requirements:
///
Expand Down

0 comments on commit b903b9f

Please sign in to comment.