Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore case of delimiter command #13

Merged
merged 4 commits into from
Feb 27, 2025
Merged

Conversation

mliezun
Copy link
Contributor

@mliezun mliezun commented Feb 27, 2025

Description

First of all, thanks for your package! This works great.

I just found that when using delimiter in lowercase or anything that is not exactly DELIMITER it was failing.

Added a little patch to detect different casing. Also added a test to check that different casing is actually processed.

Co-authored-by: VCD <verycrazydog@gmail.com>
@VeryCrazyDog VeryCrazyDog merged commit 6dbc10d into VeryCrazyDog:main Feb 27, 2025
7 checks passed
@VeryCrazyDog
Copy link
Owner

Thanks a lot for creating the PR to address the issue. I will arrange a new release on this 🚀

@mliezun
Copy link
Contributor Author

mliezun commented Feb 27, 2025

Thank you!!

@VeryCrazyDog
Copy link
Owner

New version v2.0.0 published! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants