Prevent Duplicate Employee Entries in addemp function #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adil-techcode
requested review from
Vikash-8090-Yadav,
roshangeorge97 and
sarthkdobriyal
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Our team will soon review your PR. Thanks @adil-techcode :) |
shobhitexe
reviewed
Jun 5, 2023
contracts/Sal.sol
Outdated
| @@ -20,17 +21,22 @@ contract allemp{ | |||
| function addemp ( | |||
| string memory _FirstName, | |||
| string memory _LastName, | |||
| string memory _wallet_ddress, | |||
| string memory _wallet_address, | |||
There was a problem hiding this comment.
Why wallet address is of type String it should be of type address
Eg something like "address _wallet_address" to ensure that only valid Ethereum addresses can be used as employee wallet addresses.
There was a problem hiding this comment.
ok, I will update to Variable Type String For only Valid Ethereum Address.
|
Variable Type Updated To Address and in all Wallet Address Variables |
|
Thank you @adil-techcode for taking out your valuable time in order to contribute to our project. Looking forward for more such amazing contributions :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #92
I encountered an issue in the addemp function of the allemp contract, where duplicate employee entries are not being prevented. After investigating the code, I found that the function lacks a check for existing employees, resulting in duplicate entries.
To address this issue, I propose implementing a "require" condition in the addemp function. This condition will check if the employee already exists and revert the transaction to prevent duplicate entries. This solution will enhance the efficiency of the contract by avoiding unnecessary gas fees.
#92