Create cache dir if non existing (#351)

VincentLanglet · Jan 27, 2025 · 767b2c8 · 767b2c8
1 parent 0ab7a81
commit 767b2c8
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/src/Cache/FileHandler/CacheFileHandler.php b/src/Cache/FileHandler/CacheFileHandler.php
@@ -50,7 +50,7 @@ public function write(Cache $cache): void
         } else {
             $dir = \dirname($this->file);
 
-            if (!is_dir($dir)) {
+            if (!is_dir($dir) && !@mkdir($dir, recursive: true)) {
                 throw CannotWriteCacheException::missingDirectory($this->file);
             }
 

diff --git a/tests/Cache/FileHandler/CacheFileHandlerTest.php b/tests/Cache/FileHandler/CacheFileHandlerTest.php
@@ -49,9 +49,9 @@ public function testReadSuccess(): void
 
     public function testWriteFailureMissingDirectory(): void
     {
-        $cacheFileHandler = new CacheFileHandler('/fakeDir/foo.php');
+        $cacheFileHandler = new CacheFileHandler('/fake:Dir/foo.php');
 
-        $this->expectExceptionObject(CannotWriteCacheException::missingDirectory('/fakeDir/foo.php'));
+        $this->expectExceptionObject(CannotWriteCacheException::missingDirectory('/fake:Dir/foo.php'));
         $cacheFileHandler->write(new Cache(new Signature('8.0', '1', [])));
     }
 
@@ -97,4 +97,18 @@ public function testWriteSuccess(): void
         static::assertNotFalse($permissions);
         static::assertSame('0666', substr(\sprintf('%o', $permissions), -4));
     }
+
+    public function testWriteSuccessMissingDirectory(): void
+    {
+        $file = $this->getTmpPath(__DIR__.'/Fixtures/fakeDir/foo.php');
+        $cacheFileHandler = new CacheFileHandler($file);
+
+        $cacheFileHandler->write(new Cache(new Signature('8.0', '1', [])));
+        $content = file_get_contents($file);
+        static::assertSame('{"php_version":"8.0","fixer_version":"1","rules":[],"hashes":[]}', $content);
+
+        $permissions = fileperms($file);
+        static::assertNotFalse($permissions);
+        static::assertSame('0666', substr(\sprintf('%o', $permissions), -4));
+    }
 }