Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'ordered_imports' rule from .php-cs-fixer.php #174

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

smnandre
Copy link
Contributor

Defined the same way in @symfony RuleSet (... by you 😄 )

Ref: https://cs.symfony.com/doc/rules/import/ordered_imports.html

@Symfony with config:

['imports_order' => ['class', 'function', 'const'], 'sort_algorithm' => 'alpha']

Removed:

-    'ordered_imports'                                  => [
-        'sort_algorithm' => 'alpha',
-        'imports_order'  => ['class', 'function', 'const'],
-    ],

Now defined the same way in @symfony RuleSet (https://cs.symfony.com/doc/rules/import/ordered_imports.html)

```
@symfony with config:

['imports_order' => ['class', 'function', 'const'], 'sort_algorithm' => 'alpha']
```

```diff
-    'ordered_imports'                                  => [
-        'sort_algorithm' => 'alpha',
-        'imports_order'  => ['class', 'function', 'const'],
-    ],
```
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b850eca) 100.00% compared to head (6197277) 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##                main      #174   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       566       566           
===========================================
  Files             51        51           
  Lines           1741      1741           
===========================================
  Hits            1741      1741           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VincentLanglet VincentLanglet merged commit c8f4521 into VincentLanglet:main Jan 27, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants