Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the lexer to work on Windows by permitting \r between tokens #187

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Allow the lexer to work on Windows by permitting \r between tokens #187

merged 1 commit into from
Feb 26, 2025

Conversation

chalcolith
Copy link
Contributor

Before this change, the lexer would complain about \r\n in files checked out on Windows:

error \\?\C:\Users\Gordon\Source\Repos\Vine\vine\vine\examples\hello_world.vi:1:1 - lexing error
error \\?\C:\Users\Gordon\Source\Repos\Vine\vine\vine\std\std.vi:1:1 - lexing error

This change allows \r between tokens in the Ivy and Vine lexers.

tjjfvi
tjjfvi approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@tjjfvi tjjfvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch; thanks

@tjjfvi tjjfvi added this pull request to the merge queue Feb 26, 2025
Merged via the queue into VineLang:main with commit 5fd1bdf Feb 26, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjjfvi tjjfvi tjjfvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chalcolith @tjjfvi