-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.11.1 #468
Merged
Merged
Release 1.11.1 #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requesting the record components from a struct class has a fallback to an empty list over null for objects that extend j.l.Record but do not have a record attribute. This fallback however assumes that the type has a superclass, which is not the case of j.l.Object, causing a NPE.
Vineflower's previous implementation of the type casting pattern matching in switch statements was not strict enough, considering any form of cast in the first expression of the case block a result of type pattern matching. This would incorrectly attempt to emit such type pattern matching source code for switches that simply yielded different types. This commit tightens the logic to consider a switch case a type pattern matching one if the first expression is a simple cast of the switch head's variable.
Test Results 18 files ±0 18 suites ±0 1m 4s ⏱️ +2s Results for commit a1967e8. ± Comparison against base commit 971c157. This pull request removes 767 and adds 769 tests. Note that renamed tests count towards both.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Priority: High
High priority
Type: Version Update
A pull request that merges a new version into main
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release version 1.11.1