Merge pull request #9 from Vinelab/config

Allow to configure error tagging behavior
Vinelab · Oct 24, 2019 · e0bdcec · e0bdcec
2 parents 3a714c2 + e2b360b
commit e0bdcec
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 5 deletions.
diff --git a/config/tracing.php b/config/tracing.php
@@ -60,6 +60,19 @@
         ],
     ],
 
+    /*
+    |--------------------------------------------------------------------------
+    | Errors
+    |--------------------------------------------------------------------------
+    |
+    | Whether you want to automatically tag span with error=true
+    | to denote the operation represented by the Span has failed
+    | when error message was logged
+    |
+    */
+
+    'errors' => true,
+
     /*
     |--------------------------------------------------------------------------
     | Zipkin

diff --git a/src/Listeners/TraceCommand.php b/src/Listeners/TraceCommand.php
@@ -58,6 +58,10 @@ protected function shouldTraceCommand(string $command): bool
         /** @var Command $command */
         $command = Arr::get($this->artisan->all(), $command);
 
+        if (!$command) {
+            return false;
+        }
+
         $interfaces = class_implements($command);
 
         return isset($interfaces[ShouldBeTraced::class]);

diff --git a/src/TracingServiceProvider.php b/src/TracingServiceProvider.php
@@ -26,11 +26,13 @@ public function boot()
 
         $this->app['events']->listen(CommandStarting::class, TraceCommand::class);
 
-        $this->app['events']->listen(MessageLogged::class, function (MessageLogged $event) {
-            if ($event->level == 'error') {
-                optional(Trace::getRootSpan())->tag('error', 'true');
-            }
-        });
+        if ($this->app['config']['tracing.errors']) {
+            $this->app['events']->listen(MessageLogged::class, function (MessageLogged $event) {
+                if ($event->level == 'error') {
+                    optional(Trace::getRootSpan())->tag('error', 'true');
+                }
+            });
+        }
 
         $this->app->terminating(function () {
             optional(Trace::getRootSpan())->finish();