Replaced old twitter icon with new icon #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for virtual-coffee-io processing.
|
adiati98
reviewed
Feb 1, 2024
app/components/Nav.tsx
Outdated
| xmlns="http://www.w3.org/2000/svg" | ||
| width="24" | ||
| height="24" | ||
| viewBox="0 0 512 512" |
There was a problem hiding this comment.
Hi @antriksh-9,
Is there any reason to remove the role="img" attribute and change the viewBox dimension?
adiati98
reviewed
Feb 1, 2024
app/components/Nav.tsx
Outdated
| xmlns="http://www.w3.org/2000/svg" | ||
| width="24" | ||
| height="24" | ||
| viewBox="0 0 512 512" | ||
| > | ||
| <title>Twitter</title> |
There was a problem hiding this comment.
You might also want to change this from "Twitter" to "X".
Suggested change
| <title>Twitter</title> | |
| <title>X</title> |
|
Hey @adiati98 I have made the necessary changes. |
danieltott
requested changes
Feb 2, 2024
app/components/Nav.tsx
Outdated
| @@ -82,12 +82,12 @@ export default function Nav() { | |||
| <svg | |||
| role="img" | |||
| viewBox="0 0 24 24" | |||
There was a problem hiding this comment.
Looks like we needed that viewbox change - not sure what the problem there was...
If you update that we can get this up!
Suggested change
| viewBox="0 0 24 24" | |
| viewBox="0 0 512 512" |
|
hey @danieltott I have updated the file. |
danieltott
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #1112.
Description
On the website under navbar section the twitter logo was old one.
I changed it to the new logo.
Code of Conduct