optimize codec-registration-serializer-check phase #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tried compiling few more times - each time codec-registration-serializer-check took less than 4% of total compilation time |
PawelLipski
reviewed
May 24, 2022
| @@ -44,8 +47,6 @@ class SerializerCheckCompilerPluginComponent( | |||
| val buffer = ByteBuffer.allocate(channel.size().toInt) | |||
| channel.read(buffer) | |||
| val ot = CodecRegistrationCheckerCompilerPlugin.parseCacheFile(buffer.rewind()).toSet | |||
There was a problem hiding this comment.
Huh TBH I don't like C++-style identifiers like that... esp. in a code like this, which already puts a heavy mental burden on the readers
There was a problem hiding this comment.
@PawelLipski - done - please, take a look
PawelLipski
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two snippets attached - "old" shows compilation statistics before refactor and "new" - after refactor (on Hydra).
