#101 - clippy fix

src/conf.rs

@@ -120,10 +120,7 @@ impl Conf {
         Default::default()
     }
     pub fn editor(&self) -> Option<PathBuf> {
-        let mut spth: String = match env::var(EDITOR) {
-            Ok(p) => p,
-            Err(_) => String::new(),
-        };
+        let mut spth: String = env::var(EDITOR).unwrap_or_default();
         if spth.is_empty() {
             if let Some(p) = &self.editor_path {
                 spth = p.clone();

src/main.rs

@@ -552,7 +552,7 @@ fn task_edit(stdout: &mut StandardStream, tasks: &mut todo::TaskVec, conf: &conf
                         continue;
                     }
                     // TODO: move duplicated code (here and in task_add) to a separate fn
-                    let mut tag_list = date_expr::TaskTagList::from_str(&subj, now);
+                    let mut tag_list = date_expr::TaskTagList::from_str(subj, now);
                     let soon = conf.fmt.colors.soon_days;
                     let subj = match date_expr::calculate_main_tags(now, &mut tag_list, soon) {
                         Err(e) => {
@@ -561,7 +561,7 @@ fn task_edit(stdout: &mut StandardStream, tasks: &mut todo::TaskVec, conf: &conf
                         }
                         Ok(changed) => match changed {
                             false => subj.to_string(),
-                            true => date_expr::update_tags_in_str(&tag_list, &subj),
+                            true => date_expr::update_tags_in_str(&tag_list, subj),
                         },
                     };
                     let mut cnf = conf.clone();
@@ -580,7 +580,7 @@ fn task_edit(stdout: &mut StandardStream, tasks: &mut todo::TaskVec, conf: &conf
                 writeln!(stdout, "Removed {removed_cnt} tasks, added {added_cnt} tasks.")?;
             }
         }
-        let _ = filepath.close()?;
+        filepath.close()?;
     } else if conf.dry {
         let mut clones = todo::clone_tasks(tasks, &todos);
         let updated = if conf.keep_tags {

ttdl.toml

@@ -160,7 +160,7 @@ old = "1y"
 #    true   = always add completion date, regardless of creation date is presence
 # add_completion_date_always = false
 
-# Path an external editor binary.
+# Path an external editor binary or the name of the editor binary if it is in PATH.
 # It is used when 'edit' command includes the option `--interactive`.
 # editor = ""