VIDCS-3463: On mobile, waiting room loading spinner is not present and horizontal scroll #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpettet
changed the title
cpettet
force-pushed
the
cpettet/vidcs-3463-missing-loading-spinner
branch
from
d59aed7 to
7e455e5
Compare
|
behei-vonage
approved these changes
Feb 26, 2025
| @@ -60,7 +60,7 @@ const VideoContainer = ({ username }: VideoContainerProps): ReactElement => { | |||
|
|
|||
| return ( | |||
| <div | |||
| className="relative flex w-[584px] max-w-full flex-col items-center justify-center bg-black sm:h-[328px] md:rounded-xl" | |||
| className="relative flex aspect-video w-[584px] max-w-full flex-col items-center justify-center bg-black sm:h-[328px] md:rounded-xl" | |||
There was a problem hiding this comment.
TIL I learned about aspect-video: https://tailwindcss.com/docs/aspect-ratio
and they really had to rick-roll us
|
tested, LGTM 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
Description
Will need to rebase before asking for review. This PR adds the missing loading spinner for mobile devices.
GIF
How should this be manually tested?
What are the relevant tickets?
A maintainer will add this ticket number.
Resolves VIDCS-3463
Checklist
[✅] Branch is based on
develop(notmain).[ ] Resolves a
Known Issue.[ ] If yes, did you remove the item from the
docs/KNOWN_ISSUES.md?[ ] Resolves an item reported in
Issues.If yes, which issue? Issue Number?