VIDCS-3040: There is a difference in publisher preview on waiting room and the meeting room #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to cpettet/vidcs-2983-waiting-room-cut-off
…c.ts-snapshots/Waiting-page-UI-test-1-Electron-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Google-Chrome-Fake-Devices-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Microsoft-Edge-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Opera-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-firefox-linux.png
|
maikthomas
approved these changes
Feb 19, 2025
| console.error('initPublisher error: ', err); | ||
| publisherRef.current = initPublisher( | ||
| undefined, | ||
| { insertDefaultUI: false, resolution: '1280x720' }, |
There was a problem hiding this comment.
Can we double check this is doing what we expect on real devices too?
There was a problem hiding this comment.
I updated the test instructions to test on real devices. FWIW, it looked okay on my iOS device
|
looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
Description
For mobile devices, the preview publisher in the waiting room and the one displayed for subscribers in the meeting room don't match up. See screenshots below, notice the presence or absence of the shoe tower in the before shots.
Screenshots (after)
Screenshots (before)
How should this be manually tested?
Repro'ing the issue
developor go to the live linkVerifying the fix
Trying on real devices
What are the relevant tickets?
A maintainer will add this ticket number.
Resolves VIDCS-3040
Checklist
[✅] Branch is based on
develop(notmain).[✅] Resolves a
Known Issue.[✅] If yes, did you remove the item from the
docs/KNOWN_ISSUES.md?[ ] Resolves an item reported in
Issues.If yes, which issue? Issue Number?