VIDCS-3392: BG blur state is not saved for the waiting room #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maikthomas
previously approved these changes
Feb 14, 2025
frontend/src/Context/PreviewPublisherProvider/usePreviewPublisher/usePreviewPublisher.tsx
Show resolved
Hide resolved
frontend/src/Context/PreviewPublisherProvider/usePreviewPublisher/usePreviewPublisher.tsx
Outdated
Show resolved
Hide resolved
|
Sorry, a follow-up comment. Do we save |
cpettet
reviewed
Feb 18, 2025
frontend/src/Context/PreviewPublisherProvider/usePreviewPublisher/usePreviewPublisher.tsx
Outdated
Show resolved
Hide resolved
frontend/src/Context/PreviewPublisherProvider/usePreviewPublisher/usePreviewPublisher.tsx
Outdated
Show resolved
Hide resolved
cpettet
reviewed
Feb 19, 2025
frontend/src/Context/PreviewPublisherProvider/usePreviewPublisher/usePreviewPublisher.spec.tsx
Outdated
Show resolved
Hide resolved
frontend/src/Context/PreviewPublisherProvider/usePreviewPublisher/usePreviewPublisher.spec.tsx
Outdated
Show resolved
Hide resolved
…m:Vonage/vonage-video-react-app into behei-vonage/vidcs-3392-blur-waiting-room
cpettet
approved these changes
Feb 19, 2025
|
|
looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
This PR fixes "BG blur state is not saved for the waiting room"
How should this be manually tested?
Follow the steps described in https://jira.vonage.com/browse/VIDCS-3392 to reproduce the issue.
Checkout this branch.
Follow the steps described in https://jira.vonage.com/browse/VIDCS-3392; notice that the issue is no longer present.
What are the relevant tickets?
A maintainer will add this ticket number.
Resolves VIDCS-3392
Checklist
[ ] Branch is based on
develop(notmain).[ ] Resolves a
Known Issue.[ ] If yes, did you remove the item from the
docs/KNOWN_ISSUES.md?[ ] Resolves an item reported in
Issues.If yes, which issue? Issue Number?