-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VIDCS-3319: In goodbye page on mobile, the webpage is scrollable #80
VIDCS-3319: In goodbye page on mobile, the webpage is scrollable #80
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check small viewport on desktop
…to cpettet/VIDCS-3319-mobile-scroll-goodbye-page
@maikthomas Nice catch! Here's with the latest changes. I'll try to do a viewport gif like this for any UI changes going forward. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for the gif!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
tested LGTM!! 🚀 |
What is this PR doing?
Removes some horizontal scroll on the goodbye page for mobile
Screenshots
After
Before
How should this be manually tested?
Repro'ing the issue
/goodbye
Verifying the fix
/goodbye
Verifying lack of funkiness
/goodbye
on your desktopWhat are the relevant tickets?
A maintainer will add this ticket number.
Resolves VIDCS-3319
Checklist
[✅] Branch is based on
develop
(notmain
).[ ] Resolves a
Known Issue
.[ ] If yes, did you remove the item from the
docs/KNOWN_ISSUES.md
?[ ] Resolves an item reported in
Issues
.If yes, which issue? Issue Number?