Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIDCS-3319: In goodbye page on mobile, the webpage is scrollable #80

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

cpettet
Copy link
Contributor

@cpettet cpettet commented Feb 19, 2025

What is this PR doing?

Removes some horizontal scroll on the goodbye page for mobile

Screenshots
After

fixed-real

Before

broken-real

How should this be manually tested?

Repro'ing the issue
  • on a mobile device or use mobile view, go to the goodbye page, /goodbye
  • notice there's a horizontal scrollbar
Verifying the fix
  • checkout this branch
  • on a mobile device or use mobile view, go to the goodbye page, /goodbye
  • notice there's no horizontal scrollbar
Verifying lack of funkiness
  • open /goodbye on your desktop
  • drag your window to reduce your viewport until it's as small as it can get (see gif at bottom of comments)

What are the relevant tickets?

A maintainer will add this ticket number.

Resolves VIDCS-3319

Checklist

[✅] Branch is based on develop (not main).
[ ] Resolves a Known Issue.
[ ] If yes, did you remove the item from the docs/KNOWN_ISSUES.md?
[ ] Resolves an item reported in Issues.
If yes, which issue? Issue Number?

behei-vonage
behei-vonage previously approved these changes Feb 19, 2025
Copy link
Contributor

@behei-vonage behei-vonage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@maikthomas
Copy link
Collaborator

This PR is introducing a regression
image

Copy link
Collaborator

@maikthomas maikthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check small viewport on desktop

@cpettet
Copy link
Contributor Author

cpettet commented Feb 20, 2025

Please check small viewport on desktop

@maikthomas Nice catch! Here's with the latest changes. I'll try to do a viewport gif like this for any UI changes going forward.

goodbye-gif

Copy link
Collaborator

@maikthomas maikthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the gif!

Copy link
Contributor

@behei-vonage behei-vonage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@dwivedisachin
Copy link
Collaborator

tested LGTM!! 🚀

@cpettet cpettet merged commit 6c9bd3d into develop Feb 20, 2025
8 checks passed
@cpettet cpettet deleted the cpettet/VIDCS-3319-mobile-scroll-goodbye-page branch February 20, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants