VIDCS-3322: Implement full-screen right panel on mobile #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behei-vonage
previously approved these changes
Feb 25, 2025
…ge/vonage-video-react-app into cpettet/vidcs-3322-right-panel-work
cpettet
commented
Feb 26, 2025
| @@ -24,6 +24,7 @@ const Emoji = ({ emojiWrapper }: EmojiProps): ReactElement => { | |||
| animationTimingFunction: 'linear', | |||
| animationIterationCount: 1, | |||
| maxWidth: '35%', | |||
| zIndex: 1, | |||
There was a problem hiding this comment.
Make emojis visible, even when someone has their panel/toolbar opened
v-kpheng
approved these changes
Feb 26, 2025
| Capture screenshot | ||
| </Button> | ||
| {!isMobile() && ( | ||
| // The screenshot capture relies on the getDisplayMedia browser API which is unsupported on mobile devices |
There was a problem hiding this comment.
Maybe we can use OT.checkScreenSharingCapability() instead?
There was a problem hiding this comment.
Let's keep as-is since this utility is a little simpler 🙏
frontend/src/components/MeetingRoom/ReportIssue/FeedbackForm/FilePicker/FilePicker.tsx
Show resolved
Hide resolved
| const height = isSmallViewport | ||
| ? '@apply h-[calc(100dvh_-_80px)]' | ||
| : '@apply h-[calc(100dvh_-_96px)]'; | ||
| const className = `${height} absolute top-0 ${margins} ${width} overflow-hidden rounded bg-white transition-[right] ${activeTab === 'closed' ? 'right-[-380px] hidden' : 'right-0'}`; |
There was a problem hiding this comment.
For the other reviewers, looks like mostly light refactoring.
maikthomas
approved these changes
Feb 27, 2025
| @@ -22,7 +22,7 @@ export type ChatProps = { | |||
| */ | |||
| const Chat = ({ handleClose, isOpen }: ChatProps): ReactElement | false => { | |||
| const { messages } = useSessionContext(); | |||
| const heightClass = '@apply h-[calc(100vh_-_240px)]'; | |||
| const heightClass = '@apply h-[calc(100dvh_-_240px)]'; | |||
| @@ -86,7 +86,7 @@ const ParticipantList = ({ handleClose, isOpen }: ParticipantListProps): ReactEl | |||
| </Tooltip> | |||
| </IconButton> | |||
| </div> | |||
| <List sx={{ overflowX: 'auto', height: 'calc(100vh - 240px)' }}> | |||
| <List sx={{ overflowX: 'auto', height: 'calc(100dvh - 240px)' }}> | |||
|
|
Tested LGTM!! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
Description
For small viewport devices, renders the right panel as full-screen.
Screens and GIFs (updated screenshots 2025.02.26)
How should this be manually tested?
Visual inspection on mobile
chat,participant-list,issues)closedto the panel namespamnotify our channel 🙈What are the relevant tickets?
A maintainer will add this ticket number.
Resolves VIDCS-3322
Checklist
[✅] Branch is based on
develop(notmain).[ ] Resolves a
Known Issue.[ ] If yes, did you remove the item from the
docs/KNOWN_ISSUES.md?[ ] Resolves an item reported in
Issues.If yes, which issue? Issue Number?