VIDCS-3452: Clean up language for buttons in VERA #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpettet
commented
Feb 25, 2025
Comment on lines
-32
to
-35
| const handleClickAway = (event: MouseEvent | TouchEvent) => { | ||
| const target = event.target as HTMLElement; | ||
|
|
||
| if (isSmallViewport && !target.closest('#emoji-grid-toggle')) { |
There was a problem hiding this comment.
Missed during code review, but found during Cmd + F - we don't actually have an id of emoji-grid-toggle 😂
…to cpettet/vidcs-3452-renaming-buttons
maikthomas
approved these changes
Feb 26, 2025
| return; | ||
| } | ||
| // If a user clicks the toggle button, we save their preference for later. If a user doesn't select | ||
| // If a user clicks the toggle button on mobile, we save their preference for later. If a user doesn't select |
There was a problem hiding this comment.
nit I don't think this is really a preference, I think you can just say that this will be handled by the Toolbar.
|
|
Tested LGTM!! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
This is a
ToggleButton. This is aButton. We don't have anyToggleButtons, but we had manyButtons named asToggleButton. Let's standardize this.How should this be manually tested?
What are the relevant tickets?
A maintainer will add this ticket number.
Resolves VIDCS-3452
Checklist
[✅] Branch is based on
develop(notmain).[ ] Resolves a
Known Issue.[ ] If yes, did you remove the item from the
docs/KNOWN_ISSUES.md?[ ] Resolves an item reported in
Issues.If yes, which issue? Issue Number?