-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: crowdin updates #601
fix: crowdin updates #601
Conversation
Caution Review failedThe pull request is closed. WalkthroughA new powersuit item entry has been introduced across multiple language JSON files. The new key Changes
Possibly related PRs
Suggested reviewers
Poem
Tip 🌐 Web search-backed reviews and chat
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (13)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
data/cs/languages.json (1)
18953-18956
: Verify JSON Structure ConsistencyEnsure that the surrounding entries maintain proper JSON formatting, especially regarding commas and key ordering. Although the new entry is valid, double-check that no trailing commas or formatting issues are present that might affect strict JSON parsers.
data/uk/languages.json (1)
18957-18958
: New Powersuit Localization EntryThe new key
/Lotus/StoreItems/Powersuits/Trapper/TrapperPrime
has been added with the localized value"Вобан-прайм"
. This is consistent with the overall approach of adding powersuit entries via Crowdin updates. Please verify that:
- The translation follows your localization style guidelines.
- It is consistent with similar entries in other language files (e.g., mapping to
"Vauban Prime"
in non-localized files).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (13)
data/cs/languages.json
(1 hunks)data/de/languages.json
(1 hunks)data/es/languages.json
(1 hunks)data/fr/languages.json
(1 hunks)data/it/languages.json
(1 hunks)data/ko/languages.json
(1 hunks)data/pl/languages.json
(1 hunks)data/pt/languages.json
(1 hunks)data/ru/languages.json
(1 hunks)data/sr/languages.json
(1 hunks)data/tr/languages.json
(1 hunks)data/uk/languages.json
(1 hunks)data/zh/languages.json
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Summary
🔇 Additional comments (15)
data/ko/languages.json (1)
18956-18959
: New Powersuit Entry Review: Verify Consistency and FormatThe new JSON key
"/Lotus/StoreItems/Powersuits/Trapper/TrapperPrime"
with the value"Vauban Prime"
is added correctly. Please confirm that this value is intended for the Korean locale—as other language files include localized variations (e.g., Russian and Ukrainian)—and that the JSON syntax remains valid with proper comma usage and object termination.data/zh/languages.json (2)
18953-18960
: JSON Structure and Formatting CheckThe modified hunk maintains valid JSON syntax with proper comma and brace placements. The existing entry
"AvatarImageCNY2025SnakeGlyphA"
is correctly terminated, and the new entry is cleanly integrated. Please verify that similar structural consistency is maintained across all related language files.
18957-18959
: New Powersuit Entry AdditionThe new entry
"/Lotus/StoreItems/Powersuits/Trapper/TrapperPrime"
is added with the value"Vauban Prime"
. As this PR is part of the Crowdin updates, please confirm that using the English value"Vauban Prime"
for the Chinese language file is intentional. If a localized Chinese string is expected, consider updating the value accordingly.data/tr/languages.json (1)
18956-18959
: Validate New Powersuit Entry FormatThe new key
/Lotus/StoreItems/Powersuits/Trapper/TrapperPrime
with the value"Vauban Prime"
is correctly inserted into the JSON structure. The addition follows the expected format, and the trailing comma on the previous entry (line 18956) ensures proper separation. Please verify that"Vauban Prime"
is the intended localization for the Turkish file, consistent with the values in the other language files.data/sr/languages.json (1)
18953-18960
: New Crowdin Powersuit Entry AdditionThe new entry
"/Lotus/StoreItems/Powersuits/Trapper/TrapperPrime"
with the value"Vauban Prime"
has been successfully added. The JSON structure looks consistent, and the placement after the previous entries is appropriate. Please double-check that the comma placements and overall formatting remain valid, and verify that this addition aligns with similar updates in other language files—especially with localized variations where applicable (e.g., Russian and Ukrainian).data/cs/languages.json (1)
18957-18959
: New Powersuit Entry Added CorrectlyThe new key
"/Lotus/StoreItems/Powersuits/Trapper/TrapperPrime"
with the value"Vauban Prime"
is added exactly as expected. This entry is consistent with the corresponding updates made in other language files and meets the PR objectives.data/pl/languages.json (1)
18954-18959
: New Powersuit Entry AdditionThe JSON diff correctly introduces the
/Lotus/StoreItems/Powersuits/Trapper/TrapperPrime
entry with the value"Vauban Prime"
. The syntax appears valid, and the placement within the file—right after an existing entry—is consistent with the structure observed in the other language files. Please verify that the localization rules (e.g., specialized localized values used in other languages) are consistently maintained across all affected files.data/it/languages.json (1)
18956-18959
: New Powersuit Entry Addition Approved.
The new entry"/Lotus/StoreItems/Powersuits/Trapper/TrapperPrime"
with the value"Vauban Prime"
is correctly added and follows the JSON structure. Please verify that the insertion point (with commas and braces) remains consistent with the rest of the file's formatting rules to ensure JSON validity.data/de/languages.json (1)
18956-18959
: Addition of new Powersuit entry is correctly implemented.The new key
"/Lotus/StoreItems/Powersuits/Trapper/TrapperPrime"
has been added with the value"Vauban Prime"
, which aligns with the intended update for the German localization. The JSON structure appears consistent with the existing entries.data/fr/languages.json (2)
18956-18959
: Confirm Localization Consistency for New Powersuit EntryThe new entry for
"/Lotus/StoreItems/Powersuits/Trapper/TrapperPrime"
is added with the value"Vauban Prime"
. Please verify that the French locale should indeed use this English term rather than a localized equivalent, as seen in other languages (e.g., Russian"Вобан Прайм"
or Ukrainian"Вобан-прайм"
).
18953-18960
: JSON Structure VerificationThe JSON structure appears correct. The new entry is properly inserted following the closing of the previous block, with appropriate comma placement and object delimiters.
data/pt/languages.json (1)
18956-18959
: New Powersuit Entry Addition:The new entry for
"/Lotus/StoreItems/Powersuits/Trapper/TrapperPrime"
with the value"Vauban Prime"
has been added correctly. Please verify that this entry conforms to your project’s ordering and localization conventions in the Portuguese file. If the file uses a particular key sort order (e.g., alphabetically), ensure that this insertion maintains that consistency.data/ru/languages.json (1)
18953-18960
: JSON Entry Addition – Verify Formatting and Localization.
The new entry for/Lotus/StoreItems/Powersuits/Trapper/TrapperPrime
with the value"Вобан Прайм"
correctly reflects the Russian localization update as per the PR objectives. Please verify that the comma placements and overall JSON structure remain valid after the addition to avoid any parsing issues.data/es/languages.json (2)
18956-18956
: Ensure Consistent JSON Trailing Comma FormattingThe comma added at line 18956 helps maintain proper separation between JSON objects. Please verify that this style is consistent throughout the file so that JSON parsers do not encounter any issues.
18957-18959
: Validate New Powersuit Item Entry for LocalizationThe new entry for the key
"/Lotus/StoreItems/Powersuits/Trapper/TrapperPrime"
with the value"Vauban Prime"
has been added. Since this is the Spanish language file, please confirm whether the value should remain in English or be localized for Spanish. Consistency across locales is important if translations are provided.
Code Climate has analyzed commit 295bd5e and detected 0 issues on this pull request. View more on Code Climate. |
🎉 This PR is included in version 2.20.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary by CodeRabbit