Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crowdin updates #601

Merged
merged 13 commits into from
Feb 6, 2025
Merged

fix: crowdin updates #601

merged 13 commits into from
Feb 6, 2025

Conversation

wfcd-bot-boi
Copy link
Contributor

@wfcd-bot-boi wfcd-bot-boi commented Feb 5, 2025

Summary by CodeRabbit

  • New Features
    • Added a new powersuit item labeled "Vauban Prime" to enrich the dataset across multiple languages. This update includes localized variations for enhanced international support without impacting existing entries.

Copy link

coderabbitai bot commented Feb 5, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

A new powersuit item entry has been introduced across multiple language JSON files. The new key /Lotus/StoreItems/Powersuits/Trapper/TrapperPrime is added with the value "Vauban Prime" in most files, with localized values ("Вобан Прайм" for Russian and "Вобан-прайм" for Ukrainian) in specific cases. No existing entries were modified or removed.

Changes

Files Change Summary
data/{cs, de, es, fr, it, ko, pl, pt, sr, tr, zh}/languages.json Added new entry /Lotus/StoreItems/Powersuits/Trapper/TrapperPrime with the value "Vauban Prime".
data/ru/languages.json Added new entry /Lotus/StoreItems/Powersuits/Trapper/TrapperPrime with the value "Вобан Прайм".
data/uk/languages.json Added new entry /Lotus/StoreItems/Powersuits/Trapper/TrapperPrime with the value "Вобан-прайм".

Possibly related PRs

  • feat: Add Vauban Prime #600: The changes in the main PR and the retrieved PR are directly related as both involve adding the same key "/Lotus/StoreItems/Powersuits/Trapper/TrapperPrime" with the value "Vauban Prime" to their respective JSON files.
  • fix: new crowdin updates #592: The changes in the main PR and the retrieved PR are related as both involve adding new entries for the same powersuit item, "/Lotus/StoreItems/Powersuits/Trapper/TrapperPrime" with the value "Vauban Prime" in different language JSON files.
  • fix: new crowdin updates #589: The changes in the main PR and the retrieved PR are related as both introduce a new entry for the key "/Lotus/StoreItems/Powersuits/Trapper/TrapperPrime" with the value "Vauban Prime" in different language JSON files.

Suggested reviewers

  • TobiTenno

Poem

I'm a bunny coding through the night,
Hopping in files with a joyful light,
A new key hops into each JSON file,
"Vauban Prime" or a local smile,
Each language sings in a rhythmic style—hop, hop, coding's worthwhile! 🐰

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c06dd15 and 295bd5e.

📒 Files selected for processing (13)
  • data/cs/languages.json (1 hunks)
  • data/de/languages.json (1 hunks)
  • data/es/languages.json (1 hunks)
  • data/fr/languages.json (1 hunks)
  • data/it/languages.json (1 hunks)
  • data/ko/languages.json (1 hunks)
  • data/pl/languages.json (1 hunks)
  • data/pt/languages.json (1 hunks)
  • data/ru/languages.json (1 hunks)
  • data/sr/languages.json (1 hunks)
  • data/tr/languages.json (1 hunks)
  • data/uk/languages.json (1 hunks)
  • data/zh/languages.json (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
data/cs/languages.json (1)

18953-18956: Verify JSON Structure Consistency

Ensure that the surrounding entries maintain proper JSON formatting, especially regarding commas and key ordering. Although the new entry is valid, double-check that no trailing commas or formatting issues are present that might affect strict JSON parsers.

data/uk/languages.json (1)

18957-18958: New Powersuit Localization Entry

The new key /Lotus/StoreItems/Powersuits/Trapper/TrapperPrime has been added with the localized value "Вобан-прайм". This is consistent with the overall approach of adding powersuit entries via Crowdin updates. Please verify that:

  • The translation follows your localization style guidelines.
  • It is consistent with similar entries in other language files (e.g., mapping to "Vauban Prime" in non-localized files).
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1f1d319 and c06dd15.

📒 Files selected for processing (13)
  • data/cs/languages.json (1 hunks)
  • data/de/languages.json (1 hunks)
  • data/es/languages.json (1 hunks)
  • data/fr/languages.json (1 hunks)
  • data/it/languages.json (1 hunks)
  • data/ko/languages.json (1 hunks)
  • data/pl/languages.json (1 hunks)
  • data/pt/languages.json (1 hunks)
  • data/ru/languages.json (1 hunks)
  • data/sr/languages.json (1 hunks)
  • data/tr/languages.json (1 hunks)
  • data/uk/languages.json (1 hunks)
  • data/zh/languages.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Summary
🔇 Additional comments (15)
data/ko/languages.json (1)

18956-18959: New Powersuit Entry Review: Verify Consistency and Format

The new JSON key "/Lotus/StoreItems/Powersuits/Trapper/TrapperPrime" with the value "Vauban Prime" is added correctly. Please confirm that this value is intended for the Korean locale—as other language files include localized variations (e.g., Russian and Ukrainian)—and that the JSON syntax remains valid with proper comma usage and object termination.

data/zh/languages.json (2)

18953-18960: JSON Structure and Formatting Check

The modified hunk maintains valid JSON syntax with proper comma and brace placements. The existing entry "AvatarImageCNY2025SnakeGlyphA" is correctly terminated, and the new entry is cleanly integrated. Please verify that similar structural consistency is maintained across all related language files.


18957-18959: New Powersuit Entry Addition

The new entry "/Lotus/StoreItems/Powersuits/Trapper/TrapperPrime" is added with the value "Vauban Prime". As this PR is part of the Crowdin updates, please confirm that using the English value "Vauban Prime" for the Chinese language file is intentional. If a localized Chinese string is expected, consider updating the value accordingly.

data/tr/languages.json (1)

18956-18959: Validate New Powersuit Entry Format

The new key /Lotus/StoreItems/Powersuits/Trapper/TrapperPrime with the value "Vauban Prime" is correctly inserted into the JSON structure. The addition follows the expected format, and the trailing comma on the previous entry (line 18956) ensures proper separation. Please verify that "Vauban Prime" is the intended localization for the Turkish file, consistent with the values in the other language files.

data/sr/languages.json (1)

18953-18960: New Crowdin Powersuit Entry Addition

The new entry "/Lotus/StoreItems/Powersuits/Trapper/TrapperPrime" with the value "Vauban Prime" has been successfully added. The JSON structure looks consistent, and the placement after the previous entries is appropriate. Please double-check that the comma placements and overall formatting remain valid, and verify that this addition aligns with similar updates in other language files—especially with localized variations where applicable (e.g., Russian and Ukrainian).

data/cs/languages.json (1)

18957-18959: New Powersuit Entry Added Correctly

The new key "/Lotus/StoreItems/Powersuits/Trapper/TrapperPrime" with the value "Vauban Prime" is added exactly as expected. This entry is consistent with the corresponding updates made in other language files and meets the PR objectives.

data/pl/languages.json (1)

18954-18959: New Powersuit Entry Addition

The JSON diff correctly introduces the /Lotus/StoreItems/Powersuits/Trapper/TrapperPrime entry with the value "Vauban Prime". The syntax appears valid, and the placement within the file—right after an existing entry—is consistent with the structure observed in the other language files. Please verify that the localization rules (e.g., specialized localized values used in other languages) are consistently maintained across all affected files.

data/it/languages.json (1)

18956-18959: New Powersuit Entry Addition Approved.
The new entry "/Lotus/StoreItems/Powersuits/Trapper/TrapperPrime" with the value "Vauban Prime" is correctly added and follows the JSON structure. Please verify that the insertion point (with commas and braces) remains consistent with the rest of the file's formatting rules to ensure JSON validity.

data/de/languages.json (1)

18956-18959: Addition of new Powersuit entry is correctly implemented.

The new key "/Lotus/StoreItems/Powersuits/Trapper/TrapperPrime" has been added with the value "Vauban Prime", which aligns with the intended update for the German localization. The JSON structure appears consistent with the existing entries.

data/fr/languages.json (2)

18956-18959: Confirm Localization Consistency for New Powersuit Entry

The new entry for "/Lotus/StoreItems/Powersuits/Trapper/TrapperPrime" is added with the value "Vauban Prime". Please verify that the French locale should indeed use this English term rather than a localized equivalent, as seen in other languages (e.g., Russian "Вобан Прайм" or Ukrainian "Вобан-прайм").


18953-18960: JSON Structure Verification

The JSON structure appears correct. The new entry is properly inserted following the closing of the previous block, with appropriate comma placement and object delimiters.

data/pt/languages.json (1)

18956-18959: New Powersuit Entry Addition:

The new entry for "/Lotus/StoreItems/Powersuits/Trapper/TrapperPrime" with the value "Vauban Prime" has been added correctly. Please verify that this entry conforms to your project’s ordering and localization conventions in the Portuguese file. If the file uses a particular key sort order (e.g., alphabetically), ensure that this insertion maintains that consistency.

data/ru/languages.json (1)

18953-18960: JSON Entry Addition – Verify Formatting and Localization.
The new entry for /Lotus/StoreItems/Powersuits/Trapper/TrapperPrime with the value "Вобан Прайм" correctly reflects the Russian localization update as per the PR objectives. Please verify that the comma placements and overall JSON structure remain valid after the addition to avoid any parsing issues.

data/es/languages.json (2)

18956-18956: Ensure Consistent JSON Trailing Comma Formatting

The comma added at line 18956 helps maintain proper separation between JSON objects. Please verify that this style is consistent throughout the file so that JSON parsers do not encounter any issues.


18957-18959: Validate New Powersuit Item Entry for Localization

The new entry for the key
"/Lotus/StoreItems/Powersuits/Trapper/TrapperPrime"
with the value "Vauban Prime" has been added. Since this is the Spanish language file, please confirm whether the value should remain in English or be localized for Spanish. Consistency across locales is important if translations are provided.

Copy link

codeclimate bot commented Feb 6, 2025

Code Climate has analyzed commit 295bd5e and detected 0 issues on this pull request.

View more on Code Climate.

@TobiTenno TobiTenno changed the title New Crowdin updates fix: crowdin updates Feb 6, 2025
@TobiTenno TobiTenno enabled auto-merge (squash) February 6, 2025 04:05
@TobiTenno TobiTenno merged commit 7599abd into master Feb 6, 2025
8 of 9 checks passed
@TobiTenno TobiTenno deleted the l10n branch February 6, 2025 04:06
@wfcd-bot-boi
Copy link
Contributor Author

🎉 This PR is included in version 2.20.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants