Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented interactive tutorial functionality across Android App. #64

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Implemented interactive tutorial functionality across Android App. #64

merged 4 commits into from
Oct 24, 2024

Conversation

mehad123
Copy link
Collaborator

  • Included user interaction required for some steps, before next step appeared
  • Included user interaction required as needed for certain steps, before next step appeared.
  • Included beginning pop-up when help icon is clicked to ask the user if they want to start the tutorial
  • Included option for tutorial to start at the InteractionPage.java as well

@mehad123
Implemented interactive tutorial functionality across Android App.
6b9e413 
- Included user interaction required for some steps, before next step appeared.

- Still need to add more details to RemotePage instructions.
@mehad123
Further implemented interactive tutorial functionality.
64a963c 
- Included beginning pop-up when help icon is clicked to ask the user if they want to start the tutorial

- Included option for tutorial to start at the  InteractionPage.java as well
@mehad123
Fixed merge conflicts with main
0c4accb
@mehad123 mehad123 requested a review from Fahim-zzz October 24, 2024 19:35
@mehad123
Added tutorial help icon to activity_main.xml
6eb2123 
for some reason it didnt get added to the commit in the previous commit
Fahim-zzz
Fahim-zzz reviewed Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@Fahim-zzz Fahim-zzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be issues when users do not follow the predicted path with the tutorial. Some bug fixing is necessary. For example, exiting the tutorial isn't doesn't allow me to restart the tutorial until no is pressed and then retried.

@mehad123
Copy link
Collaborator Author

That's not a bug, the pop-up message is pointing out for the user to conduct the step, and then the next step of the tutorial will continue on after that.

@Fahim-zzz
Copy link
Collaborator

That's not a bug, the pop-up message is pointing out for the user to conduct the step, and then the next step of the tutorial will continue on after that.

My fault, I like the direction, although some edge case handling will need to be implemented later on. LGTM

Fahim-zzz
Fahim-zzz approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@Fahim-zzz Fahim-zzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the direction, although some edge case handling will need to be implemented later on. LGTM

@mehad123
Copy link
Collaborator Author

I like the direction, although some edge case handling will need to be implemented later on. LGTM

Sounds good, I'll keep that in mind.

@mehad123 mehad123 merged commit c752544 into main Oct 24, 2024
2 checks passed
@mehad123 mehad123 deleted the mehad-v3 branch November 5, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fahim-zzz Fahim-zzz Fahim-zzz approved these changes

Assignees
No one assigned
Labels
sprint#2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mehad123 @Fahim-zzz