Skip to content

Commit

Permalink
Refactor : TripMemberMsg에 NumberOfPeople 추가
Browse files Browse the repository at this point in the history
  • Loading branch information
kdjun99 committed Jan 11, 2024
1 parent 10fdaa1 commit 2b7b339
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
public record TripMemberMsg(
Long tripId,
List<TripMemberInfoMsg> connectedMembers,
List<TripMemberInfoMsg> tripMembers
List<TripMemberInfoMsg> tripMembers,
Long numberOfPeople
) {
}
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,12 @@ public class TripService {
@Transactional
public void connectMember(String tripId, MemberConnectMsg memberConnectMsg) {
HashMap<Long, TripMemberInfoMsg> connectedMemberMap = tripConnectedMemberMap.getOrDefault(tripId, new HashMap<>());
Trip trip = tripRepository.getReferenceById(Long.parseLong(tripId));
Optional<TripMemberInfoMsg> tripMemberInfoByMemberId = memberRepository.findTripMemberInfoByMemberId(memberConnectMsg.memberId());
tripMemberInfoByMemberId.ifPresent(tripMemberInfoMsg -> connectedMemberMap.put(memberConnectMsg.memberId(), tripMemberInfoMsg));

TripMemberMsg tripMemberMsg = new TripMemberMsg(
Long.parseLong(tripId), connectedMemberMap.values().stream().toList(), memberRepository.findTripMemberInfoByTripId(Long.parseLong(tripId))
Long.parseLong(tripId), connectedMemberMap.values().stream().toList(), memberRepository.findTripMemberInfoByTripId(Long.parseLong(tripId)), trip.getNumberOfPeople()
);
tripConnectedMemberMap.put(tripId, connectedMemberMap);
sendToKafkaAndSave(tripMemberMsg);
Expand All @@ -59,10 +60,11 @@ public void connectMember(String tripId, MemberConnectMsg memberConnectMsg) {
@Transactional
public void disconnectMember(String tripId, MemberDisconnectMsg memberDisconnectMsg) {
HashMap<Long, TripMemberInfoMsg> connectedMemberMap = tripConnectedMemberMap.getOrDefault(tripId, new HashMap<>());
Trip trip = tripRepository.getReferenceById(Long.parseLong(tripId));
connectedMemberMap.remove(memberDisconnectMsg.memberId());

TripMemberMsg tripMemberMsg = new TripMemberMsg(
Long.parseLong(tripId), connectedMemberMap.values().stream().toList(), memberRepository.findTripMemberInfoByTripId(Long.parseLong(tripId))
Long.parseLong(tripId), connectedMemberMap.values().stream().toList(), memberRepository.findTripMemberInfoByTripId(Long.parseLong(tripId)), trip.getNumberOfPeople()
);
tripConnectedMemberMap.put(tripId, connectedMemberMap);
sendToKafkaAndSave(tripMemberMsg);
Expand Down Expand Up @@ -185,8 +187,9 @@ private TripMemberMsg getTripMemberMsg(String tripId) {
return objectMapper.convertValue(cached, TripMemberMsg.class);
}
HashMap<Long, TripMemberInfoMsg> connectedMemberMap = tripConnectedMemberMap.getOrDefault(tripId, new HashMap<>());
Trip trip = tripRepository.getReferenceById(Long.parseLong(tripId));
TripMemberMsg tripMemberMsg = new TripMemberMsg(
Long.parseLong(tripId), connectedMemberMap.values().stream().toList(), memberRepository.findTripMemberInfoByTripId(Long.parseLong(tripId))
Long.parseLong(tripId), connectedMemberMap.values().stream().toList(), memberRepository.findTripMemberInfoByTripId(Long.parseLong(tripId)), trip.getNumberOfPeople()
);
redisCache.save(MEMBER, tripId, tripMemberMsg);
return tripMemberMsg;
Expand Down

0 comments on commit 2b7b339

Please sign in to comment.