Fix regression in "Continously update Move Speed"

Introduced in ca76ed1, which changed the IsPlayerMoving
check to not listen to events but check every frame. That every frame
handler overwrote the MoveSpeed every frame handler.

So combine the handlers since they both want to run every frame.

This has been broken for 6m.

Fixes: #4630

WeakAuras/GenericTrigger.lua

@@ -3633,22 +3633,23 @@ end
 
 -- Player Moving
 do
+  --- @class PlayerMovingFrame
+  --- @field moving integer|nil
+  --- @field speed integer|nil
+
+  --- @type PlayerMovingFrame|Frame|nil
   local playerMovingFrame = nil
-  local moving;
 
   local function PlayerMoveUpdate()
     Private.StartProfileSystem("generictrigger");
-    if (moving ~= IsPlayerMoving() or moving == nil) then
-      moving = IsPlayerMoving();
+    local moving = IsPlayerMoving()
+    if (playerMovingFrame.moving ~= moving or playerMovingFrame.moving == nil) then
+      playerMovingFrame.moving = moving
       WeakAuras.ScanEvents("PLAYER_MOVING_UPDATE")
     end
-    Private.StopProfileSystem("generictrigger");
-  end
 
-  local function PlayerMoveSpeedUpdate()
-    Private.StartProfileSystem("generictrigger");
     local speed = GetUnitSpeed("player")
-    if speed ~= playerMovingFrame.speed then
+    if playerMovingFrame.speed ~= speed then
       playerMovingFrame.speed = speed
       WeakAuras.ScanEvents("PLAYER_MOVE_SPEED_UPDATE")
     end
@@ -3658,19 +3659,12 @@ do
   function WeakAuras.WatchForPlayerMoving()
     if not(playerMovingFrame) then
       playerMovingFrame = CreateFrame("Frame");
+      --- @cast playerMovingFrame PlayerMovingFrame
       Private.frames["Player Moving Frame"] =  playerMovingFrame;
+      playerMovingFrame.speed = GetUnitSpeed("player")
     end
     playerMovingFrame:SetScript("OnUpdate", PlayerMoveUpdate)
   end
-
-  function WeakAuras.WatchPlayerMoveSpeed()
-    if not(playerMovingFrame) then
-      playerMovingFrame = CreateFrame("Frame");
-      Private.frames["Player Moving Frame"] =  playerMovingFrame;
-    end
-    playerMovingFrame.speed = GetUnitSpeed("player")
-    playerMovingFrame:SetScript("OnUpdate", PlayerMoveSpeedUpdate)
-  end
 end
 
 -- Item Count

WeakAuras/Prototypes.lua

@@ -8867,17 +8867,16 @@ Private.event_prototypes = {
       }
     },
     internal_events = function(trigger, untrigger)
-      local events = { "WA_DELAYED_PLAYER_ENTERING_WORLD", "PLAYER_MOVING_UPDATE" }
+      local events = { "WA_DELAYED_PLAYER_ENTERING_WORLD" }
       if trigger.use_moveSpeed then
         tinsert(events, "PLAYER_MOVE_SPEED_UPDATE")
       end
       return events
     end,
     loadFunc = function(trigger)
       if trigger.use_moveSpeed then
-        WeakAuras.WatchPlayerMoveSpeed()
+        WeakAuras.WatchForPlayerMoving()
       end
-      WeakAuras.WatchForPlayerMoving()
     end,
     init = function()
       local ret = [[