Add fixes and improvements from Micropython #120

andrewleech · 2022-04-25T11:23:23Z

An earlier version of this Wiznet driver has been in use in micropython (primarily on the stm32 port) since 2014, with a few additions being made to it since.

As part of my work in micropython/micropython#8540 I'm updating the driver to use the current version from here, preferably as a submodule to make future updates easier to maintain. For this to happen smoothly though, I'm hoping to submit a clean version of the micropython patches here.

There are a couple of commits here that as-is will present no change, but instead allow third part projects like micropython to integrate the library more smoothly.

A couple of other commits add features / bug fixes found previously. Hopefully the commit descriptions provide enough context for these changes.

@dpgeorge

Originally by @dpgeorge from: micropython/micropython@7da9145

@dpgeorge

No change to any function names by default. 3rd party projects can set a compiler define of WIZCHIP_PREFIXED_EXPORTS=1 to rename all exported names from socket, eg "close" becomes "wizchip_close". Originally by @dpgeorge from: micropython/micropython@9d2bf9c

@dpgeorge

Originally by @dpgeorge from: micropython/micropython@d8f2392

#define WIZCHIP_YIELD() can be globally set to yield from thread to improve the performance of connect, send, recv, sento and recvfrom. Originally by liweiwei@yeweitech.com from: micropython/micropython@73e387c

@dpgeorge

Enabling WIZCHIP_USE_MAX_BUFFER will make the TX/RX buffers the maximum available size, for use with MACRAW mode. Adapted from original version by @dpgeorge at: micropython/micropython@cd9de63

irinakim12 · 2022-05-22T22:53:48Z

Sorry. We can't merge micropython related code here.
This repository is a library for C language.
For that code, it seems that we need to create a separate library for MicroPython.

andrewleech · 2022-05-22T23:24:42Z

Hi @irinakim12 this PR does not include any micropython specific code, it was carefully cleaned up to only include C changes that should be relevant to any users of this library. I listed micropython in the title simply because these were commits / changes originally done by other's under the micropython project.

jimmo · 2022-07-21T01:01:19Z

Hi @irinakim12 I'm from the MicroPython project. We're currently using @andrewleech's fork of this repo but would prefer to point our submodule to the official repo instead.

As Andrew said, this PR doesn't include anything MicroPython-specific, rather it's just general improvements that make it easy for a project (such as MicroPython) to embed this library. (In particular, avoiding name collisions with other functions).

irinakim12 · 2022-12-09T04:53:38Z

@andrewleech Could I ask you for an answer ? :)

andrewleech · 2022-12-09T06:34:43Z

Sure, what's the question?

irinakim12 · 2022-12-15T01:23:00Z

Sure, what's the question?

I write the review about your Pull request last week.
I ask you for an answer and code fix for this.

andrewleech · 2022-12-15T01:28:07Z

I write the review about your Pull request last week. I ask you for an answer and code fix for this.

Sorry I can't see any review comments on this PR?
Do you mean a discussion on one/some of the "Change MICROPY_PY_LWIP setting" PR's in micropython?

irinakim12 · 2022-12-06T05:00:09Z

Ethernet/socket.c

 #include "socket.h"
+#include "wizchip_conf.h"


"#inlclude wizchip_conf.h" is already assigned in the socket.h

we didn't use the memset.
Please delete this phrase.

irinakim12 · 2022-12-06T05:03:23Z

Ethernet/socket.c

+                  // socket, and trying to get POSIX behaviour we return 0 because:
+                  // "If no messages are available to be received and the peer has per?
+                  //  formed an orderly shutdown, recv() shall return 0".
+                  // TODO this return value clashes with SOCK_BUSY in non-blocking mode.


Please delete the comments

irinakim12 · 2022-12-06T05:15:19Z

Ethernet/wizchip_conf.h

@@ -278,7 +294,7 @@ typedef struct __WIZCHIP
         uint8_t (*_read_byte)   (void);
         void    (*_write_byte)  (uint8_t wb);
         void    (*_read_burst)  (uint8_t* pBuf, uint16_t len);
-         void    (*_write_burst) (uint8_t* pBuf, uint16_t len);
+         void    (*_write_burst) (const uint8_t* pBuf, uint16_t len);


Why use const values only when using write_bust function?
Any special reason?

irinakim12 · 2022-12-06T05:29:29Z

Ethernet/socket.c

@@ -100,9 +103,21 @@ uint8_t  sock_pack_info[_WIZCHIP_SOCK_NUM_] = {0,};
      if(len == 0) return SOCKERR_DATALEN;   \
   }while(0);              \

+void WIZCHIP_EXPORT(socket_reset)(void) {


Why do you need to use a reset function?

irinakim12 · 2022-12-06T05:34:04Z

Ethernet/wizchip_conf.c

@@ -496,6 +501,9 @@ int8_t wizchip_init(uint8_t* txsize, uint8_t* rxsize)
 		}
 	#endif
   }
+
+   WIZCHIP_EXPORT(socket_reset)();


Why is the reset function only used here?

irinakim12 · 2022-12-18T23:11:01Z

I write the review about your Pull request last week. I ask you for an answer and code fix for this.

Sorry I can't see any review comments on this PR? Do you mean a discussion on one/some of the "Change MICROPY_PY_LWIP setting" PR's in micropython?

sorry. Review of this PR has been put on hold. Now you can check out my comments.

Properly fix ARP bug with W5200 chipset.

8cbbc03

Originally by @dpgeorge from: micropython/micropython@7da9145

DeeJay mentioned this pull request Apr 25, 2022

Support for Wiznet RP2040 HAT in mainstream rp2 MicroPython firmware? Wiznet/RP2040-HAT-MicroPython#8

Open

pi-anl added 5 commits April 27, 2022 06:27

Add socket_reset; fix orderly shutdown in recv.

1a272d7

Originally by @dpgeorge from: micropython/micropython@d8f2392

Allow improvements in performance of socket ops with threading.

009940c

#define WIZCHIP_YIELD() can be globally set to yield from thread to improve the performance of connect, send, recv, sento and recvfrom. Originally by liweiwei@yeweitech.com from: micropython/micropython@73e387c

Protect write_burst buffer arg as const.

0fb14c8

w5200: Allow selecting maximum fixed buffer size for MACRAW.

0803fc5

Enabling WIZCHIP_USE_MAX_BUFFER will make the TX/RX buffers the maximum available size, for use with MACRAW mode. Adapted from original version by @dpgeorge at: micropython/micropython@cd9de63

andrewleech force-pushed the micropython branch from 1a16731 to 0803fc5 Compare April 26, 2022 20:27

andrewleech mentioned this pull request Apr 27, 2022

rp2: Add Wiznet W5100S-EVB-Pico board. micropython/micropython#8540

Closed

irinakim12 mentioned this pull request Nov 11, 2022

ports/rp2: Change MICROPY_PY_LWIP setting value and netinfo structure. micropython/micropython#9862

Closed

2 tasks

irinakim12 changed the base branch from master to micropython December 5, 2022 04:42

irinakim12 self-assigned this Dec 9, 2022

irinakim12 reviewed Dec 18, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add fixes and improvements from Micropython #120

Add fixes and improvements from Micropython #120

andrewleech commented Apr 25, 2022

irinakim12 commented May 22, 2022 •

edited

Loading

andrewleech commented May 22, 2022

jimmo commented Jul 21, 2022

irinakim12 commented Dec 9, 2022

andrewleech commented Dec 9, 2022 •

edited

Loading

irinakim12 commented Dec 15, 2022

andrewleech commented Dec 15, 2022

irinakim12 Dec 6, 2022

irinakim12 Dec 6, 2022

irinakim12 Dec 6, 2022

irinakim12 Dec 6, 2022

irinakim12 Dec 6, 2022

irinakim12 commented Dec 18, 2022

Add fixes and improvements from Micropython #120

Are you sure you want to change the base?

Add fixes and improvements from Micropython #120

Conversation

andrewleech commented Apr 25, 2022

irinakim12 commented May 22, 2022 • edited Loading

andrewleech commented May 22, 2022

jimmo commented Jul 21, 2022

irinakim12 commented Dec 9, 2022

andrewleech commented Dec 9, 2022 • edited Loading

irinakim12 commented Dec 15, 2022

andrewleech commented Dec 15, 2022

irinakim12 Dec 6, 2022

Choose a reason for hiding this comment

irinakim12 Dec 6, 2022

Choose a reason for hiding this comment

irinakim12 Dec 6, 2022

Choose a reason for hiding this comment

irinakim12 Dec 6, 2022

Choose a reason for hiding this comment

irinakim12 Dec 6, 2022

Choose a reason for hiding this comment

irinakim12 commented Dec 18, 2022

irinakim12 commented May 22, 2022 •

edited

Loading

andrewleech commented Dec 9, 2022 •

edited

Loading