FEDX-2722: Update the ignore field to ignore everything, not just specific checks
#148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tables, and only used outside of lib/
matthewnitschke-wk
changed the title
matthewnitschke-wk
changed the title
ignore field to ignore everything, not just specific checks
bender-wk
changed the title
ignore field to ignore everything, not just specific checksignore field to ignore everything, not just specific checks
nicbiggs-wk
approved these changes
Mar 6, 2025
danielszopa-wk
approved these changes
Mar 6, 2025
There was a problem hiding this comment.
+1 I can confirm this fixes the issue this xbrl-module PR was hitting.
brianneal-wf
approved these changes
Mar 6, 2025
|
@Workiva/release-management-p |
btr-rmconsole-4
bot
deleted the
support_ignore_for_packges_with_executables_only_used_outside_lib
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEDX-2722
Motivation
Currently, the
ignorefield only applies to some rules in the dependency_validator execution processIf you're explicitly ignoring a dependency, it doesn't make sense that some rules can still fail. As such, this PR changes the expectation of evaluation, where when
ignoreexists for a package, its full ignored from dep evaluationTip
Note, this PR's base is
v4and notmasterWe need to backpatch the v4 version with this change, and this will be manually released once merged into v4. We will create a similar PR in master so the functionality between these branches doesn't change
Testing/QA Instructions
ignoreindeed ignores it