Batch Amendment

[dangell7]

High Level Overview of Change

XLS spec: https://github.com/XRPLF/XRPL-Standards/blob/master/XLS-0056d-batch/README.md

Context of Change

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Refactor (non-breaking change that only restructures code)
• Performance (increase or change in throughput and/or latency)
• Tests (you added tests for code that already exists, or your new feature included in this PR)
• Documentation update
• Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
• Release

API Impact

• Public API: New feature (new methods and/or new fields)
• Public API: Breaking change (in general, breaking changes should only impact the next api_version)
• libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
• Peer protocol change (must be backward compatible or bump the peer protocol version)

Test Plan

https://gist.github.com/dangell7/3afbe8c4597a58dc2b02be598f9b7d54

[codecov]

Codecov Report

Attention: Patch coverage is 90.96639% with 43 lines in your changes missing coverage. Please review.

Project coverage is 78.2%. Comparing base (1b75dc8) to head (e213b6c).
Report is 3 commits behind head on develop.

Files with missing lines	Patch %	Lines
src/xrpld/app/tx/detail/applySteps.cpp	40.0%	15 Missing ⚠️
src/xrpld/overlay/detail/PeerImp.cpp	0.0%	10 Missing ⚠️
src/xrpld/app/misc/NetworkOPs.cpp	71.4%	6 Missing ⚠️
src/xrpld/app/tx/detail/Transactor.cpp	94.8%	4 Missing ⚠️
src/libxrpl/protocol/STTx.cpp	97.6%	2 Missing ⚠️
src/xrpld/app/ledger/detail/OpenLedger.cpp	33.3%	2 Missing ⚠️
src/xrpld/app/tx/detail/apply.cpp	96.7%	2 Missing ⚠️
src/xrpld/app/tx/detail/Batch.cpp	99.1%	1 Missing ⚠️
src/xrpld/ledger/detail/OpenView.cpp	50.0%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #5060     +/-   ##
=========================================
+ Coverage     78.1%   78.2%   +0.1%     
=========================================
  Files          790     793      +3     
  Lines        67340   67712    +372     
  Branches      8155    8168     +13     
=========================================
+ Hits         52585   52923    +338     
- Misses       14755   14789     +34     

Files with missing lines	Coverage Δ
include/xrpl/protocol/Batch.h	100.0% <100.0%> (ø)
include/xrpl/protocol/Feature.h	100.0% <ø> (ø)
include/xrpl/protocol/HashPrefix.h	100.0% <ø> (ø)
include/xrpl/protocol/STTx.h	100.0% <ø> (ø)
include/xrpl/protocol/TER.h	100.0% <100.0%> (ø)
include/xrpl/protocol/TxMeta.h	93.8% <100.0%> (+2.1%)	⬆️
include/xrpl/protocol/detail/transactions.macro	100.0% <100.0%> (ø)
src/libxrpl/protocol/InnerObjectFormats.cpp	100.0% <100.0%> (ø)
src/libxrpl/protocol/TER.cpp	100.0% <ø> (ø)
src/libxrpl/protocol/TxMeta.cpp	96.5% <100.0%> (+0.3%)	⬆️
... and 22 more

... and 6 files with indirect coverage changes