DRAFT: Ximinez/lending xls 66

[ximinez]

Base branch is #5224

High Level Overview of Change

Context of Change

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Refactor (non-breaking change that only restructures code)
• Performance (increase or change in throughput and/or latency)
• Tests (you added tests for code that already exists, or your new feature included in this PR)
• Documentation update
• Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
• Release

API Impact

• Public API: New feature (new methods and/or new fields)
• Public API: Breaking change (in general, breaking changes should only impact the next api_version)
• libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
• Peer protocol change (must be backward compatible or bump the peer protocol version)

[codecov]

Codecov Report

Attention: Patch coverage is 89.77505% with 50 lines in your changes missing coverage. Please review.

Project coverage is 78.1%. Comparing base (4e862e0) to head (c69ac64).

Files with missing lines	Patch %	Lines
src/xrpld/app/tx/detail/InvariantCheck.cpp	44.6%	36 Missing ⚠️
include/xrpl/protocol/Indexes.h	0.0%	4 Missing ⚠️
src/libxrpl/protocol/Indexes.cpp	0.0%	4 Missing ⚠️
src/xrpld/app/tx/detail/Transactor.h	70.0%	3 Missing ⚠️
src/xrpld/app/tx/detail/VaultCreate.cpp	75.0%	2 Missing ⚠️
src/xrpld/app/tx/detail/VaultSet.cpp	87.5%	1 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                  @@
##           ximinez/Bronek/vault   #5270   +/-   ##
====================================================
  Coverage                  78.1%   78.1%           
====================================================
  Files                       802     802           
  Lines                     68698   68655   -43     
  Branches                   8264    8293   +29     
====================================================
- Hits                      53670   53646   -24     
+ Misses                    15028   15009   -19     

Files with missing lines	Coverage Δ
include/xrpl/basics/base_uint.h	97.4% <100.0%> (+<0.1%)	⬆️
include/xrpl/protocol/SField.h	100.0% <ø> (ø)
include/xrpl/protocol/STLedgerEntry.h	100.0% <ø> (ø)
include/xrpl/protocol/detail/ledger_entries.macro	100.0% <100.0%> (ø)
include/xrpl/protocol/detail/transactions.macro	100.0% <ø> (ø)
src/libxrpl/protocol/InnerObjectFormats.cpp	100.0% <100.0%> (ø)
src/libxrpl/protocol/SField.cpp	83.0% <100.0%> (+1.6%)	⬆️
src/xrpld/app/tx/detail/AMMBid.cpp	90.9% <100.0%> (+0.4%)	⬆️
src/xrpld/app/tx/detail/AMMBid.h	100.0% <ø> (ø)
src/xrpld/app/tx/detail/AMMClawback.cpp	100.0% <100.0%> (ø)
... and 100 more

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.