Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added conan profile cleanup. #5278

Closed
wants to merge 2 commits into from

Conversation

rrmanukyan
Copy link
Contributor

@rrmanukyan rrmanukyan commented Feb 6, 2025

High Level Overview of Change

Added build environment cleanup

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@bthomee bthomee requested a review from legleux February 6, 2025 22:12
@@ -71,6 +71,7 @@ jobs:
nproc
- name: configure Conan
run : |
rm -rf ~/.conan/profiles/default
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would fix the repetition of the "-DBOOST_ASIO_DISABLE_CONCEPTS" over and over again but what needs to be done is the ${{ github.workspace }} needs to be cleaned up.

The runner needs to be more ephemeral. The profile collecting that define repeatedly is evidence of that.

I can be more explicit in a few hours.

@rrmanukyan
Copy link
Contributor Author

The changes were added to the target branch

@rrmanukyan rrmanukyan closed this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants