Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small typos #5279

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Fix small typos #5279

merged 2 commits into from
Feb 13, 2025

Conversation

code0xff
Copy link
Contributor

@code0xff code0xff commented Feb 7, 2025

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@vvysokikh1 vvysokikh1 assigned vvysokikh1 and unassigned vvysokikh1 Feb 7, 2025
@vvysokikh1 vvysokikh1 added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Feb 7, 2025
@ximinez
Copy link
Collaborator

ximinez commented Feb 7, 2025

@code0xff Can you affirm this is ready to merge?

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.2%. Comparing base (a079bac) to head (2c551b4).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5279     +/-   ##
=========================================
- Coverage     78.2%   78.2%   -0.0%     
=========================================
  Files          790     790             
  Lines        67639   67638      -1     
  Branches      8160    8164      +4     
=========================================
- Hits         52869   52862      -7     
- Misses       14770   14776      +6     
Files with missing lines Coverage Δ
include/xrpl/protocol/AccountID.h 61.5% <ø> (ø)
include/xrpl/protocol/Sign.h 100.0% <ø> (ø)
src/xrpld/app/main/Main.cpp 79.0% <ø> (ø)

... and 4 files with indirect coverage changes

Impacted file tree graph

@code0xff
Copy link
Contributor Author

code0xff commented Feb 7, 2025

@code0xff Can you affirm this is ready to merge?

Yes, this is ready to merge. The changes are just simple typo fixes. Please let me know if there's anything else that needs to be done.

@bthomee bthomee added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Feb 10, 2025
@bthomee
Copy link
Collaborator

bthomee commented Feb 12, 2025

@code0xff would you be able to sign your commits?

@bthomee bthomee merged commit b02b8d0 into XRPLF:develop Feb 13, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants