Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(callbacks/lightning): populate callback for lightning #114

Merged
merged 4 commits into from
Dec 17, 2023
Merged

fix(callbacks/lightning): populate callback for lightning #114

merged 4 commits into from
Dec 17, 2023

Conversation

XuehaiPan
Copy link
Owner

Issue Type

  • Bug fix

Description

Populate the implementation for GpuStatsLogger callback to nvitop.lightning based on lightning.pytorch..callbacks.Callback.

Motivation and Context

Fixes #112
Closes #113

@XuehaiPan XuehaiPan added api Something related to the core APIs dependencies Pull requests that update a dependency file labels Dec 17, 2023
@XuehaiPan XuehaiPan self-assigned this Dec 17, 2023
@XuehaiPan XuehaiPan mentioned this pull request Dec 17, 2023
Closed
@XuehaiPan XuehaiPan merged commit bff355b into main Dec 17, 2023
1 check passed
@XuehaiPan XuehaiPan deleted the lightning-callbacks branch December 17, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@XuehaiPan XuehaiPan

Labels
api Something related to the core APIs dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Pytorch lightning callback
1 participant
@XuehaiPan