Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed selfgauss debug and other trace problem #561

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Pinsplash
Copy link

@Pinsplash Pinsplash commented Jan 10, 2025

bxt_hud_selfgauss

  • 2 and below show singleplayer behavior
  • 3 and above show multiplayer behavior
  • Even numbers show coordinates of line traces
  • All reasons for failing to selfgauss are now shown
  • Threshold translated to time value, more intuitive
  • Hit group display may have been broken before, definitely works now

to fix bxt_hud_selfgauss not working correctly, one condition was removed from ServerDLL::TraceLine. this needs to be removed or else the 2nd and 3rd line traces incorrectly say they stopped at 0, 0, 0.

since the condition was added to avoid a crash when playing a demo in bxt_hud_entity_info, all places that used a trace involving the player will now exit harmlessly if the player entity doesn't exist

bxt_hud_selfgauss
* 2 and below show singleplayer behavior
* 3 and above show multiplayer behavior
* Even numbers show coordinates of line traces
* All reasons for failing to selfgauss are now shown
* Threshold translated to time value, more intuitive
* Hit group display may have been broken before, definitely works now

to fix bxt_hud_selfgauss not working correctly, one condition was removed from ServerDLL::TraceLine. this needs to be removed or else the 2nd and 3rd line traces incorrectly say they hit an object at 0, 0, 0.

since the condition was added to avoid a crash when playing a demo in bxt_hud_entity_info, all places that used a trace involving the player will now exit harmlessly if the player entity doesn't exist
@YaLTeR YaLTeR requested a review from SmileyAG January 10, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant