Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower Python version requirement, fix license header detection #4

Merged
merged 2 commits into from
Mar 17, 2024

Conversation

hakimifr
Copy link
Member

  • Minimum Python version required has been lowered.
  • Previously, the add_license used the header with new lines at the beginning, which fails on some files where license header starts directly from top. This caused license header to be added again, doubling the header the file has. Remove that new line.

@hakimifr hakimifr requested a review from prathamdby March 17, 2024 17:36
Copy link
Member

@prathamdby prathamdby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@prathamdby prathamdby merged commit 1f63b8d into main Mar 17, 2024
1 check passed
@prathamdby prathamdby deleted the staging/hakimi branch March 17, 2024 17:43
@prathamdby prathamdby added the enhancement Enhancement to existing features label Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants