Refactor scribereader_test.py and scribereader.py

This commit refactors the scribereader_test.py and scribereader.py files. It introduces a new function, get_log_namespace, which retrieves the log namespace from a yelpsoa-configs configuration file. The function is used in the PaaSTALogs class in scribereader.py to set the namespace for logging. The commit also includes unit tests for the get_log_namespace function.

Closes TRON-2275

tests/utils/scribereader_test.py

@@ -2,8 +2,10 @@
 from unittest import mock
 
 import pytest
+import yaml
 
 import tron.utils.scribereader
+from tron.utils.scribereader import get_log_namespace
 from tron.utils.scribereader import read_log_stream_for_action_run
 
 try:
@@ -420,3 +422,63 @@ def test_read_log_stream_for_action_run_min_date_and_max_date_for_long_output():
     # The expected output should be max_lines plus the
     # extra line for 'This output is truncated.' message
     assert len(output) == max_lines + 1
+
+
+def test_get_log_namespace_yml_file_found():
+    action_run_id = "namespace.job.1234.action"
+    paasta_cluster = "fake_cluster"
+    config_content = """
+    job:
+        actions:
+            action:
+                service: test_service
+    """
+    with mock.patch("builtins.open", mock.mock_open(read_data=config_content)), mock.patch(
+        "yaml.safe_load", return_value=yaml.safe_load(config_content)
+    ):
+        result = get_log_namespace(action_run_id, paasta_cluster)
+        assert result == "test_service"
+
+
+def test_get_log_namespace_file_not_found():
+    action_run_id = "namespace.job.1234.action"
+    paasta_cluster = "fake_cluster"
+    with mock.patch("builtins.open", side_effect=FileNotFoundError):
+        result = get_log_namespace(action_run_id, paasta_cluster)
+        assert result == "namespace"
+
+
+def test_get_log_namespace_yaml_error():
+    action_run_id = "namespace.job.1234.action"
+    paasta_cluster = "fake_cluster"
+    with mock.patch("builtins.open", mock.mock_open(read_data="invalid_yaml")), mock.patch(
+        "yaml.safe_load", side_effect=yaml.YAMLError
+    ):
+        result = get_log_namespace(action_run_id, paasta_cluster)
+        assert result == "namespace"
+
+
+def test_get_log_namespace_generic_error():
+    action_run_id = "namespace.job.1234.action"
+    paasta_cluster = "fake_cluster"
+    with mock.patch("builtins.open", mock.mock_open(read_data="some_data")), mock.patch(
+        "yaml.safe_load", side_effect=Exception
+    ):
+        result = get_log_namespace(action_run_id, paasta_cluster)
+        assert result == "namespace"
+
+
+def test_get_log_namespace_service_not_found():
+    action_run_id = "namespace.job.1234.action"
+    paasta_cluster = "fake_cluster"
+    config_content = """
+    job:
+        actions:
+            action:
+                command: "sleep 10"
+    """
+    with mock.patch("builtins.open", mock.mock_open(read_data=config_content)), mock.patch(
+        "yaml.safe_load", return_value=yaml.safe_load(config_content)
+    ):
+        result = get_log_namespace(action_run_id, paasta_cluster)
+        assert result == "namespace"

tron/utils/scribereader.py

@@ -9,7 +9,8 @@
 from typing import Optional
 from typing import Tuple
 
-import staticconf  # type: ignore
+import staticconf
+import yaml  # type: ignore
 
 from tron.config.static_config import get_config_watcher
 from tron.config.static_config import NAMESPACE
@@ -81,12 +82,32 @@ def get_scribereader_host_and_port(ecosystem: str, superregion: str, region: str
     return host, port
 
 
+def get_log_namespace(action_run_id: str, paasta_cluster: str) -> str:
+    namespace, job_name, _, action = action_run_id.split(".")
+    for ext in ["yaml", "yml"]:
+        try:
+            with open(f"/nail/etc/services/{namespace}/tron-{paasta_cluster}.{ext}") as f:
+                config = yaml.safe_load(f)
+                service = config.get(job_name, {}).get("actions", {}).get(action, {}).get("service", None)
+                if service:
+                    return service
+        except FileNotFoundError:
+            log.warning(f"yelp-soaconfig file tron-{paasta_cluster}.{ext} not found.")
+        except yaml.YAMLError as e:
+            log.error(f"Error parsing YAML file tron-{paasta_cluster}.{ext}: {e}")
+        except Exception as e:
+            log.error(f"Error reading service for {action} from file tron-{paasta_cluster}.{ext}: {e}")
+
+    return namespace
+
+
 class PaaSTALogs:
     def __init__(self, component: str, paasta_cluster: str, action_run_id: str) -> None:
         self.component = component
         self.paasta_cluster = paasta_cluster
         self.action_run_id = action_run_id
-        namespace, job_name, run_num, action = action_run_id.split(".")
+        _, job_name, run_num, action = action_run_id.split(".")
+        namespace = get_log_namespace(action_run_id, paasta_cluster)
         # in our logging infra, things are logged to per-instance streams - but
         # since Tron PaaSTA instances are of the form `job_name.action`, we need
         # to escape the period since some parts of our infra will reject streams