Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setMinPinLength implementation #123

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Fix setMinPinLength implementation #123

merged 1 commit into from
Mar 21, 2024

Conversation

AdamVe
Copy link
Member

@AdamVe AdamVe commented Mar 21, 2024

Also adds integration tests.

dainnilsson
dainnilsson approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@dainnilsson dainnilsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdamVe AdamVe merged commit 89c3a99 into main Mar 21, 2024
5 checks passed
@AdamVe AdamVe deleted the adamve/fix/ctap_setminpinlen branch March 21, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dainnilsson dainnilsson dainnilsson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdamVe @dainnilsson